Skip to content

ipnetwork: add netmask constructors - #103

Merged
achanda merged 2 commits into
achanda:masterfrom
lucab:ups/parse-net-pair
Nov 28, 2019
Merged

achanda merged 2 commits into
achanda:masterfrom
lucab:ups/parse-net-pair

Conversation

@lucab

@lucab lucab commented Nov 27, 2019

Copy link
Copy Markdown

This adds constructors to build all network types from a network
address and network mask pair.
It also rustfmt the whole project.

Luca BRUNO added 2 commits November 27, 2019 15:50
This adds constructors to build all network types from a network
address and network mask pair.
@achanda

achanda commented Nov 28, 2019

Copy link
Copy Markdown
Owner

Thanks @lucab !

@achanda
achanda merged commit 43a38d4 into achanda:master Nov 28, 2019
@lucab
lucab deleted the ups/parse-net-pair branch November 28, 2019 13:54
@lucab

lucab commented Nov 28, 2019 •

Copy link
Copy Markdown
Author

@achanda thank you for maintaining this!
For reference, our consumer is at https://github.com/coreos/afterburn and I have an in-flight PR where I first had to introduce this logic: https://github.com/coreos/afterburn/pull/316/files#diff-7ee10d7f83c9157dc687e0411d9a2f4dR54-R59

@achanda

achanda commented Nov 28, 2019

Copy link
Copy Markdown
Owner

Thanks for the pointer. I can cut a release today if this is required now. Otherwise, I was planning to do it mid-December.

@lucab

lucab commented Nov 28, 2019

Copy link
Copy Markdown
Author

No worries, it will take some time any way for all the bits to be in place. I'll jump on the new version without hurry once it's available, and in the meanwhile the small bit of logic duplication is perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants