Skip to content

Edit check_rdf_scan so that SPDX rdf tests don't automatically pass #3448 - #3451

Merged
AyanSinhaMahapatra merged 1 commit into
aboutcode-org:developfrom
armintaenzertng:fix_rdf_tests
Jul 17, 2023
Merged

Edit check_rdf_scan so that SPDX rdf tests don't automatically pass #3448#3451
AyanSinhaMahapatra merged 1 commit into
aboutcode-org:developfrom
armintaenzertng:fix_rdf_tests

Conversation

@armintaenzertng

@armintaenzertng armintaenzertng commented Jul 12, 2023 •
edited by AyanSinhaMahapatra
Loading

Copy link
Copy Markdown
Contributor

Also adapted the expected.rdf files from tests that failed thereafter.

Fixes #3448

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@armintaenzertng
Edit check_rdf_scan so that SPDX rdf tests don't automatically pass
b3511a8 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng armintaenzertng mentioned this pull request Jul 17, 2023
Closed
AyanSinhaMahapatra
AyanSinhaMahapatra requested changes Jul 17, 2023
View reviewed changes

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See comments below

Comment thread tests/formattedcode/test_output_spdx.py
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Jul 17, 2023
View reviewed changes

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks++

@AyanSinhaMahapatra
AyanSinhaMahapatra merged commit 200fb10 into aboutcode-org:develop Jul 17, 2023
@armintaenzertng
armintaenzertng deleted the fix_rdf_tests branch July 17, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SPDX rdf tests pass automatically

2 participants

@armintaenzertng @AyanSinhaMahapatra