Skip to content

KiB and MiB are wrongly used in place of kB and MB #254

Open

Description

@evilaliv3

The current implementation for byteFmt and kbFmt is using KiB(kibibyte) and MiB (mebibyte) are wrongly used in place of kB(kilobyte) and MB (megabyte).

The issue should be fixed in compatibility with the most common convension of softwares like the linux filesystem, chrome, firefox.

Evidences of the issue are present on the following ticket: globaleaks/globaleaks-whistleblowing-software#2044

A diffuse explaination is present on the wikipedia page: https://en.wikipedia.org/wiki/Kilobyte

image

Activity

  1. evilaliv3 commented on Aug 12, 2017

    @evilaliv3
    Author

    In the real only linux and mac use the correct Kb definitions while Microsoft still use the 1024 size so that it is not possible to obtain something completely "correct".

  2. nmoinvaz commented on Oct 10, 2017

    @nmoinvaz

    It might be better to modify the filters to take a second parameter which is the base 10 or 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions