Skip to content

fix(compat): list push notification configs in the v0.3 REST client - #1424

Merged
mykytanetipa merged 2 commits into
a2aproject:mainfrom
RaphaelFakhri:fix/compat-rest-list-push-configs
Nov 5, 2026
Merged

mykytanetipa merged 2 commits into
a2aproject:mainfrom
RaphaelFakhri:fix/compat-rest-list-push-configs

Conversation

@RaphaelFakhri

Copy link
Copy Markdown
Contributor

Description

CompatRestTransport.list_task_push_notification_configs raised NotImplementedError, so a client using the HTTP+JSON binding could not list push notification configs on a v0.3 agent. The v0.3 REST binding defines the call as GET /v1/tasks/{id}/pushNotificationConfigs. This SDK's own v0.3 compat server (REST03Adapter) serves it, and the v0.3 JSON-RPC and gRPC client transports already implement it.

This change sends the GET request and converts the ListTaskPushNotificationConfigResponse with the existing converters, as the v0.3 gRPC transport does. delete_task_push_notification_config keeps raising NotImplementedError, since the compat REST server does not mount a delete route.

The unit test that asserted NotImplementedError now checks the request path and the parsed configs. Listing two configs against a server built with create_rest_routes(..., enable_v0_3_compat=True) also returns both of them now.

Fixes #1423

@RaphaelFakhri
RaphaelFakhri requested a review from a team as a code owner November 4, 2026 09:10
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🧪 Code Coverage (vs main)

⬇️ Download Full Report

Base PR Delta
src/a2a/compat/v0_3/proto_utils.py 90.57% 90.76% 🟢 +0.18%
src/a2a/compat/v0_3/rest_transport.py 95.63% 95.71% 🟢 +0.08%
Total 93.51% 93.52% 🟢 +0.01%

Generated by coverage-comment.yml

@mykytanetipa mykytanetipa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mykytanetipa
mykytanetipa merged commit d830036 into a2aproject:main Nov 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: v0.3 REST client raises NotImplementedError for list_task_push_notification_configs

2 participants