sonar(tests): long tail, 3 single findings - #300
Merged
Merged
Conversation
- TypeMapperTests: IrValue theory data uses DisableDiscoveryEnumeration (xUnit1045), matching ConfigEqualityTests and ApiEquivalenceLoweringTests. - LoweringOracleGen: Call.Method renamed Callee so it no longer shadows the outer Method property (S3218). - PairGen: the per-site mutant lambda moves to a named Mutants method so the nested lambdas in Pairs bind once (CS9236). Pins dotnet_diagnostic.xUnit1045 and CS9236 severity = error for tests/. Ticket: GH-182 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…method (CS9236) The pinned CS9236 found a second site: the nested Sum lambdas in Count. Ticket: GH-182 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the three one-off Sonar findings under
tests/. All three still reproduced onHEAD(641e318); line numbers had drifted for two of them.TypeMapperTests.csxUnit1045 (TheoryData<string, IrValue>)[MemberData(nameof(Defaults), DisableDiscoveryEnumeration = true)], the same fixConfigEqualityTestsandApiEquivalenceLoweringTestsalready useLoweringOracleGen.csS3218 (Call.Methodshadows the outerMethodproperty)CalleePairGen.csCS9236 (nested lambdas inPairsbound 100+ times)Mutants(op, rendered)methodAcceptance criteria
policy.jsonc..editorconfig[tests/**.cs]now setsdotnet_diagnostic.xUnit1045.severity = erroranddotnet_diagnostic.CS9236.severity = error. With both at error, CI's build is what proves no other test file trips either rule../build.ps1 -Integrationgreen: see CI on this PR.src/coverage is unaffected.Closes #182
🤖 Generated with Claude Code