Skip to content

sonar(S1192): String literals should not be duplicated - #285

Merged
Zafnok merged 2 commits into
mainfrom
sonar/s1192
Sep 29, 2026
Merged

sonar(S1192): String literals should not be duplicated#285
Zafnok merged 2 commits into
mainfrom
sonar/s1192

Conversation

@Zafnok

@Zafnok Zafnok commented Sep 29, 2026

Copy link
Copy Markdown
Owner

Replaces the duplicated literals with private constants: LegacySide/ModernSide in CompareCommand, ModernSide in ReplayDriverFactory, False in MsBuildEvaluator. No behaviour change.

  • All 4 findings fixed (each re-verified at HEAD; none had evaporated).
  • Gate: left to CI, per equiv-quality-gates.
  • No pragma, coverage exclusion or gate change.

Closes #271

🤖 Generated with Claude Code

Zafnok and others added 2 commits September 28, 2026 20:35
@Zafnok @claude
refactor: name the duplicated side and "false" literals (S1192)
73eb4f1 
Ticket: GH-271

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Zafnok @claude
refactor(frontend-csharp): build both side drivers in one helper
0c59010 
Removes the three copies of the legacy/modern driver step that Sonar counted as new-code duplication.

Ticket: GH-271

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 29, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Zafnok
Zafnok merged commit bd8e379 into main Sep 29, 2026
18 checks passed
@Zafnok
Zafnok deleted the sonar/s1192 branch September 29, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sonar(S1192): String literals should not be duplicated

1 participant

@Zafnok