Skip to content

Positional parameters in generated files #31

Open

Description

@chahuistle

CTDs do not include this information. So the schema should be modified to support positional parameters, which are to be used in output CWL/ToolConfig files.

Activity

  1. chahuistle commented on Aug 29, 2017

    @chahuistle
    ContributorAuthor

    CWL now supports positional parameters (see c0a2f82).

    We still need a clever way to solve this in Galaxy, since the command-line generation right now doesn't use positional information, so that's a little refactoring right there.

  2. bgruening commented on Aug 29, 2017

    @bgruening
    Contributor

    @chahuistle if you plan to put more work into this I would not consider to enhance the commandline generation. Simply create the CTD in the wrapper with the option in Galaxy and let CTD tools consume CTD files as they are supposed to do. Way less error prone and way less code.

  3. chahuistle commented on Aug 29, 2017

    @chahuistle
    ContributorAuthor

    @bgruening I'm not sure I get it...

    What do you mean by "creating the CTD in the wrapper with the option in Galaxy". Any chance of providing an example?

    It would be great if positional parameters are also supported in the generation of ToolConfigs, so yeah, this is sort of something I'd like to work on.

    Thanks!

  4. bgruening commented on Aug 29, 2017

    @bgruening
    Contributor

    Positional arguments are supported, but my point is that this is not at all needed. You can simply generate a CDT file with filled arguments inside of the Galaxy wrapper and pass this file to the CDT tools.

    I assume all CTD tools can just consume the CTD file to get its arguments, without the need of a commandline right?

    Have a look of this simple command line:
    https://github.com/bgruening/galaxytools/blob/master/tools/sklearn/nn_classifier.xml#L10

    which uses a file that is created on-the-fly here (this should be your CTD file): https://github.com/bgruening/galaxytools/blob/master/tools/sklearn/nn_classifier.xml#L15

    Call me if this is not really clear.

  5. chahuistle commented on Aug 29, 2017

    @chahuistle
    ContributorAuthor

    I'll have a look at it, thanks.

    I needed to fix the CWL part quite urgently. The way CWL and Galaxy handle positional parameters are quite different and the CWL converter was just broken. There's a workaround this issue in the Galaxy converter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions