You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CTDs do not include this information. So the schema should be modified to support positional parameters, which are to be used in output CWL/ToolConfig files.
CWL now supports positional parameters (see c0a2f82).
We still need a clever way to solve this in Galaxy, since the command-line generation right now doesn't use positional information, so that's a little refactoring right there.
@chahuistle if you plan to put more work into this I would not consider to enhance the commandline generation. Simply create the CTD in the wrapper with the option in Galaxy and let CTD tools consume CTD files as they are supposed to do. Way less error prone and way less code.
What do you mean by "creating the CTD in the wrapper with the option in Galaxy". Any chance of providing an example?
It would be great if positional parameters are also supported in the generation of ToolConfigs, so yeah, this is sort of something I'd like to work on.
Positional arguments are supported, but my point is that this is not at all needed. You can simply generate a CDT file with filled arguments inside of the Galaxy wrapper and pass this file to the CDT tools.
I assume all CTD tools can just consume the CTD file to get its arguments, without the need of a commandline right?
I needed to fix the CWL part quite urgently. The way CWL and Galaxy handle positional parameters are quite different and the CWL converter was just broken. There's a workaround this issue in the Galaxy converter.
Activity
chahuistle commentedon Aug 29, 2017
CWL now supports positional parameters (see c0a2f82).
We still need a clever way to solve this in Galaxy, since the command-line generation right now doesn't use positional information, so that's a little refactoring right there.
bgruening commentedon Aug 29, 2017
@chahuistle if you plan to put more work into this I would not consider to enhance the commandline generation. Simply create the CTD in the wrapper with the option in Galaxy and let CTD tools consume CTD files as they are supposed to do. Way less error prone and way less code.
chahuistle commentedon Aug 29, 2017
@bgruening I'm not sure I get it...
What do you mean by "creating the CTD in the wrapper with the option in Galaxy". Any chance of providing an example?
It would be great if positional parameters are also supported in the generation of ToolConfigs, so yeah, this is sort of something I'd like to work on.
Thanks!
bgruening commentedon Aug 29, 2017
Positional arguments are supported, but my point is that this is not at all needed. You can simply generate a CDT file with filled arguments inside of the Galaxy wrapper and pass this file to the CDT tools.
I assume all CTD tools can just consume the CTD file to get its arguments, without the need of a commandline right?
Have a look of this simple command line:
https://github.com/bgruening/galaxytools/blob/master/tools/sklearn/nn_classifier.xml#L10
which uses a file that is created on-the-fly here (this should be your CTD file): https://github.com/bgruening/galaxytools/blob/master/tools/sklearn/nn_classifier.xml#L15
Call me if this is not really clear.
chahuistle commentedon Aug 29, 2017
I'll have a look at it, thanks.
I needed to fix the CWL part quite urgently. The way CWL and Galaxy handle positional parameters are quite different and the CWL converter was just broken. There's a workaround this issue in the Galaxy converter.