Skip to content

Lag caused by custom crafting #39

Description

@DavidRSM29

Describe the bug
When a player is crafting anything on the crafting table, the server TPS go down.
Expected behavior
I would expect a performance loss but not like what I am experiencing.

Server (please complete the following information):

  • Server Software Tuinity
  • Minecraft version 1.16.5
  • Java version Java 16

Additional context
https://timings.aikar.co/?id=28ce2d458e3d4e27aeec57e020efc6a3

Activity

  1. WolfyScript commented on Aug 8, 2021

    @WolfyScript
    Owner

    That is a lot of lag indeed.
    I am aware that the current algorithm isn't as optimized, and I started working on a new one last month, but it still takes some time.
    Current tests concluded that this new system will be up to 2x faster when putting items into the grid and up to 6x faster when taking out the result. (Of course, these might vary IRL)
    So I am working on improving it.

  2. DavidRSM29 commented on Aug 8, 2021

    @DavidRSM29
    Author

    will it help if I put more netty threads to the server? I have 4 that its the default

  3. WolfyScript commented on Aug 8, 2021

    @WolfyScript
    Owner

    No, it is independent of netty.
    What you could do is make sure that only the necessary recipes can be mirrored.
    By default, all recipes can be mirrored horizontally, disabling it for all the recipes that don't require it should help.
    options

  4. DavidRSM29 commented on Aug 8, 2021

    @DavidRSM29
    Author

    ohh, I will do that, thanks 😄

  5. RhythmicSys commented on Aug 12, 2021

    @RhythmicSys

    Am also having this issue- just thought I'd put this here in case it's of any use
    https://timings.pl3x.net/?id=35d8c8d546cb45feb38edebdbfcdd42f#plugins

    This applies to normal vanilla recipes as well, does not matter what is being crafted, whether it is custom or not. I have made most of my recipes able to be flipped and if possible, shapeless entirely :3 (I was just crafting sea lanterns with this timings report, none of my custom recipes share those ingredients)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions