Skip to content

4357 bug scenegraph origanize error #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fangsmile merged 2 commits into from
Aug 28, 2025
Merged

4357 bug scenegraph origanize error #4371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5521ede
fix: when has many columns expand columnTree scenegraph node y error …
fangsmile Aug 22, 2025
6e8bd98
docs: update changlog of rush
fangsmile Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vtable/4357-bug-scenegraph-origanize-error_2025-08-22-06-26.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: when has many columns expand columnTree scenegraph node y error #4357\n\n",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "892739385@qq.com"
}
3 changes: 3 additions & 0 deletions packages/vtable/src/scenegraph/group-creater/column-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ export function createComplexColumn(
y = (columnGroup.lastChild as Group).attribute.y + (columnGroup.lastChild as Group).attribute.height;
} else if (columnGroup.colHeight) {
y = columnGroup.colHeight;
} else if (rowStart >= table.columnHeaderLevelCount) {
// 这个if判断为了解决#4357 当传入的rowStart例如50但是columnGroup中并没有其他cell的情况下，上面逻辑有问题y赋值的0 导致新建单元格错位
y = table.getRowsHeight(table.columnHeaderLevelCount, rowStart - 1);
}

for (let j = rowStart; j <= rowEnd; j++) {
Expand Down