Addition changes to enable Verify.Cli app - #888
Merged
Conversation
Contributor
Author
|
Coming back to this, as https://github.com/flcdrg/Verify.Cli/ is just wanting to compare a file, it doesn't have the extra type stuff that the existing constructor requires (and trying to fake it gets messy). This change, or something like it should enable file verification by being able to reference to the Verify nupkg |
flcdrg
force-pushed
the
cli
branch
2 times, most recently
from
May 22, 2023 00:10
85ab34e to
6ca5938
Compare
Contributor
Author
|
Hmm.. that change to ApplyScrubbers is breaking tests. I've got something wrong there. |
flcdrg
force-pushed
the
cli
branch
2 times, most recently
from
May 22, 2023 11:14
44f6058 to
1696076
Compare
Contributor
Author
|
I think this is ready to review. Mac build had some kind of hiccup and needs to be re-queued. |
SimonCropp
reviewed
May 22, 2023
SimonCropp
reviewed
May 22, 2023
flcdrg
force-pushed
the
cli
branch
2 times, most recently
from
May 25, 2023 12:13
9b8ad0d to
7ab3f40
Compare
Contributor
Author
|
Test is failing.. trying to figure out why. I can't help but notice that there's two dots in the deleted output - that seems suspicious. |
SimonCropp
reviewed
May 25, 2023
- Add simple constructor to InnerVerifier for just comparing files - Ensure replacements field is valid even if we haven't called UseAssembly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assists with #716