Skip to content

Addition changes to enable Verify.Cli app - #888

Merged
SimonCropp merged 1 commit into
VerifyTests:mainfrom
flcdrg:cli
May 27, 2023
Merged

Addition changes to enable Verify.Cli app#888
SimonCropp merged 1 commit into
VerifyTests:mainfrom
flcdrg:cli

Conversation

@flcdrg

@flcdrg flcdrg commented May 21, 2023

Copy link
Copy Markdown
Contributor
  • Add simple constructor to InnerVerifier for just comparing files
  • Ensure replacements field is valid even if we haven't called UseAssembly

Assists with #716

@flcdrg

flcdrg commented May 21, 2023

Copy link
Copy Markdown
Contributor Author

Coming back to this, as https://github.com/flcdrg/Verify.Cli/ is just wanting to compare a file, it doesn't have the extra type stuff that the existing constructor requires (and trying to fake it gets messy).

This change, or something like it should enable file verification by being able to reference to the Verify nupkg

@flcdrg
flcdrg force-pushed the cli branch 2 times, most recently from 85ab34e to 6ca5938 Compare May 22, 2023 00:10
@flcdrg

flcdrg commented May 22, 2023

Copy link
Copy Markdown
Contributor Author

Hmm.. that change to ApplyScrubbers is breaking tests. I've got something wrong there.

@flcdrg
flcdrg force-pushed the cli branch 2 times, most recently from 44f6058 to 1696076 Compare May 22, 2023 11:14
@flcdrg

flcdrg commented May 22, 2023

Copy link
Copy Markdown
Contributor Author

I think this is ready to review. Mac build had some kind of hiccup and needs to be re-queued.

Comment thread src/Verify/Serialization/Scrubbers/ApplyScrubbers.cs Outdated
Comment thread src/Verify/Verifier/InnerVerifier.cs
@flcdrg
flcdrg force-pushed the cli branch 2 times, most recently from 9b8ad0d to 7ab3f40 Compare May 25, 2023 12:13
@flcdrg

flcdrg commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

Test is failing.. trying to figure out why. I can't help but notice that there's two dots in the deleted output - that seems suspicious.

VerifyException: Directory: C:\dev\git\Verify\src\Verify.Tests

VerifyException
Directory: C:\dev\git\Verify\src\Verify.Tests
Delete:
  - sample.verified..txt
Equal:
  - Received: sample.txt
    Verified: sample.verified.txt

Comment thread src/Verify/Verifier/InnerVerifier.cs Outdated
@SimonCropp

Copy link
Copy Markdown
Member

- Add simple constructor to InnerVerifier for just comparing files
- Ensure replacements field is valid even if we haven't called UseAssembly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants