Repository navigation
Fix compiler diagnostics and release-evidence validation - #403
Conversation
Enforce the existing depth bound in recursive readable terms and types. Cover 50,000-level closed and unclosed input through the API and CLI, exact readable boundaries, and independent guard-removal plants. Closes #374.
|
I’m investigating the failed honesty job on c055e4a and will keep the gate intact. I’ll post the focused reproduction and correction once checked. |
|
Fixed the honesty failure in 519694d: VR-11 had eight steps against the Gherkin subset’s six-step bound. Consolidated related outcomes into six steps, preserving every expectation and leaving the gate intact. Reproduced the original failure locally; all five bdd meta-tests (including planted-defect falsifiability), validate-model, and diff checks now pass. The published tree equals the locally reviewed 5749680e4 tree byte for byte. Run 41605700263 passed the full bdd-verification leg on the original implementation, including VR-11. A separate blocker remains: bdd-compiler job 125815139388 aborted with a stack overflow in conformance_tc_03. The ARM, Windows, and rest failures inspected were the same eight-step honesty failure corrected here. No old jobs were manually rerun; the new head supplies fresh CI evidence. |
Retain the 128-level reader bound and recursion-limit category, explain smaller definitions joined by prim append, and cover the boundary and validation refusals. Closes #375.
Retain both VERIFICATION records after their append-only conflict. Model, specification links, formatting and diff checks pass on the resolved tree.
Comment only: retain the 240-minute timeout and every workflow token. Closes #235.
|
Maintainer coordination: I am preparing one combined maintenance integration from this head plus the existing #401 and #406 heads, preserving their histories and reviews. #401's complete gate is green but its verification-record appendix conflicts with the updated release line; #406 needs its intentionally refused fixtures classified under the existing negative-input convention. The repeated TC-03 overflow and RP-18 failure are being investigated separately, with no acceptance checks disabled. The combined, reviewed final tree will run one complete gate before landing, avoiding three separate full matrices after these integrations. Its final description will name the precise issue closures (#377, #374, #375 and #235); the original PRs stay open until their source is incorporated and reviewable. No identity regeneration is part of this maintenance integration. |
Combine authoring depth refusal, complete policy diagnostics, semantic JSON nesting advice, negative fixture classification and release-gate listing consumption. Reuse rendered semantic mappings for policy source anchors. Preserve both feature histories and verification records. Tree matches reviewed local integration 0cfb8c4f48e17945cdab7ae5d5a4757d05cfb594 exactly. Final-head acceptance CI remains required.
afflom
left a comment
There was a problem hiding this comment.
Reviewed the final combined tree411f68fa973103b1e1d03e6cff0dae2ae75ead6b, including independent Sol 6.1 reviews and focused validation. Exact published parents preserve all source from #401/#406. Appendix resolutions retain every record; the fixture correction preserves bytes and AU-08's existing invariant; the release-gate change preserves every acceptance predicate; semantic policy anchors reuse already-rendered Lean mappings in declaration order. No identity regeneration or acceptance exemption was introduced.
Source review is clear, conditional on the complete final-head gate. Do not merge or close #374/#375/#377/#235/#408 while any required result is incomplete or failing. The earlier TC-03 and ordinary RP-18 failures have not been assigned a proven cause; this review does not relabel them as infrastructure failures or authorize blind reruns.
Preserve both verification appendices and carry the already-tested BS-20 generated artifacts unchanged. No source conflict or regeneration.
|
#364 has now landed as 0a01df6 after all 43 jobs passed. This advances release/v0.4, so the current run here remains evidence for the old integration tree, not final merge clearance against the new base. I prepared the updated merge locally as 215a9d5 (tree 88d8b657f1ab621bf736b9d7e5d97fcb9c834e5e), preserving exact parents 39399a2 and 0a01df6. Only the VERIFICATION append conflicted; both records survive. All source-only blobs from both sides are preserved; shared source/model deltas retain their reviewed patches. Formatting, model audits (469 IDs/86 codes), spec links and all five BDD meta-tests pass on the correctly rooted local tree. No identity inputs or generated oracles changed relative to the new base. The remote branch is deliberately unchanged while CI 41634793106 finishes. I will publish the reviewed integration afterward and require complete final-tree evidence before merge. Please avoid a duplicate base-merge patch or using the old-tree checks as new-tree acceptance. #413 remains a separate stacked optimization pending this landing. |
afflom
left a comment
There was a problem hiding this comment.
Reviewed the BS-20 release-base integration at tree 88d8b657f1ab621bf736b9d7e5d97fcb9c834e5e. All BS-20-only and maintenance-only source blobs retain their parent contents; shared source/model changes retain the reviewed patches. Only the VERIFICATION append conflicted, and both records survive. No identity input or generated artifact changed relative to the landed release base. Correctly rooted formatting/model (469 IDs, 86 codes)/spec links and all five BDD meta-tests pass.
The previous maintenance tree passed the complete 42-job gate 41634793106, honesty and reproducibility before this integration was published. That establishes the old tree, not this one. Source review is clear, but merge and closure of #374/#375/#377/#235/#408 still require complete new-head CI and actual merge-tree equality. This is a source review COMMENT on a self-authored PR, not self-approval.
Deep authoring terms could abort, semantic JSON depth errors offered no remedy, and verification reported only the first axiom-policy failure at the project manifest. This maintenance integration fixes those diagnostics and a separately reproduced release-evidence pipe failure.
This replaces #401 and #406 with one reviewed final integration and one complete gate. Their exact published heads are preserved in this branch's merge history, along with all verification records. The branch now also includes the landed BS-20 release commit 0a01df6. No compiler identity input or generated oracle was changed.
Validation:
Reviewed integration tree: 88d8b657f1ab621bf736b9d7e5d97fcb9c834e5e at head 215a9d5. Its parents preserve the prior maintenance head and landed release/v0.4 at 0a01df6; only the verification-record append conflicted, and both records remain intact.
Closes #374.
Closes #375.
Closes #377.
Closes #235.
Closes #408.
Landed as
5a44fe49e5d73569c3bb377bb28b56e463ee0547onrelease/v0.4. Actual merge tree88d8b657f1ab621bf736b9d7e5d97fcb9c834e5eequals the final reviewed/tested head and synthetic merge tree. Issues #374, #375, #377, #235 and #408 were explicitly closed with this evidence after landing.