Skip to content

fix(ui5-flexible-column-layout): rename noArrows property to hideArrows #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilhan007 merged 2 commits into from
May 28, 2021
Merged

fix(ui5-flexible-column-layout): rename noArrows property to hideArrows #3352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0529dda
fix(ui5-flexible-column-layout): rename noArrows property to hideArrows
fifoosid May 28, 2021
4b8d14a
add docs
fifoosid May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/fiori/src/FlexibleColumnLayout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ const metadata = {
* @type {boolean}
* @defaultvalue false
* @public
* @since 1.0.0-rc.15
*/
noArrows: {
hideArrows: {
type: Boolean,
},

Expand Down Expand Up @@ -592,11 +593,11 @@ class FlexibleColumnLayout extends UI5Element {
}

get showStartArrow() {
return this.noArrows ? false : this.startArrowVisibility;
return this.hideArrows ? false : this.startArrowVisibility;
}

get showEndArrow() {
return this.noArrows ? false : this.endArrowVisibility;
return this.hideArrows ? false : this.endArrowVisibility;
}

get startArrowVisibility() {
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/test/pages/FCL.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,11 @@

<!-- ex2 -->
<br><br>
<ui5-title class="sectionTitle">Master-Detail: Detail expanded + no-arrows</ui5-title>
<ui5-title class="sectionTitle">Master-Detail: Detail expanded + hide-arrows</ui5-title>
<ui5-toggle-button id="switchBtn2" class="testButton">Set to TwoColumnsMidExpanded</ui5-toggle-button>
<br><br>

<ui5-flexible-column-layout id="fcl2" layout="TwoColumnsMidExpanded" no-arrows>
<ui5-flexible-column-layout id="fcl2" layout="TwoColumnsMidExpanded" hide-arrows>
<!-- start column -->
<div style="box-sizing: border-box;" slot="startColumn">
<div style="padding: 1rem">
Expand Down