Repository navigation
refactor(ui5-avatar): rename backgroundColor property to colorScheme - #3222
Merged
Merged
Conversation
Closed
Contributor
|
make sure you merge the commit not with "chore" to have it in the release notes as it is breaking change |
fifoosid
changed the title
ilhan007
previously approved these changes
May 12, 2021
dobrinyonkov
previously approved these changes
May 12, 2021
ilhan007
approved these changes
May 12, 2021
ilhan007
requested changes
May 12, 2021
ilhan007
left a comment
ilhan007
left a comment
Contributor
There was a problem hiding this comment.
@nnaydenow has concerns about the new name
ilhan007
changed the title
ilhan007
changed the title
dobrinyonkov
approved these changes
May 18, 2021
ilhan007
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3107
BREAKING_CHANGE: The backgroundColor property of
ui5-avataris changed to colorScheme