Skip to content

fix(ui5-side-navigation): remove aria-roledescription from navigation list #14252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TeodorTaushanov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui5-side-navigation): remove aria-roledescription from navigation list #14252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fiori/cypress/specs/SideNavigation.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,7 +1507,7 @@ describe("Side Navigation Accessibility", () => {
cy.get("#sideNav")
.shadow()
.find(".ui5-sn-flexible")
.should("have.attr", "aria-roledescription", "Navigation List Menu Bar");
.should("not.have.attr", "aria-roledescription");

@GerganaKremenska GerganaKremenska Nov 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the test


cy.get("#sideNav")
.invoke("attr", "style", "height: 100px");
Expand Down
11 changes: 0 additions & 11 deletions packages/fiori/src/SideNavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ import SideNavigationTemplate from "./SideNavigationTemplate.js";

import {
SIDE_NAVIGATION_POPOVER_HIDDEN_TEXT,
SIDE_NAVIGATION_COLLAPSED_LIST_ARIA_ROLE_DESC,
SIDE_NAVIGATION_LIST_ARIA_ROLE_DESC,
SIDE_NAVIGATION_OVERFLOW_ACCESSIBLE_NAME,
SIDE_NAVIGATION_FLEXIBLE_LIST_LABEL,
SIDE_NAVIGATION_FIXED_LIST_LABEL,
Expand Down Expand Up @@ -382,15 +380,6 @@ class SideNavigation extends UI5Element {
return SideNavigation.i18nBundle.getText(SIDE_NAVIGATION_POPOVER_HIDDEN_TEXT);
}

get ariaRoleDescNavigationList() {
let key = SIDE_NAVIGATION_LIST_ARIA_ROLE_DESC;
if (this.collapsed) {
key = SIDE_NAVIGATION_COLLAPSED_LIST_ARIA_ROLE_DESC;
}

return SideNavigation.i18nBundle.getText(key);
}

get navigationMenuPrimaryHiddenText() {
return SideNavigation.i18nBundle.getText(SIDE_NAVIGATION_FLEXIBLE_LIST_LABEL);
}
Expand Down
4 changes: 0 additions & 4 deletions packages/fiori/src/SideNavigationTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export default function SideNavigationTemplate(this: SideNavigation) {
<div role="menubar"
class="ui5-sn-list ui5-sn-flexible"
aria-orientation="vertical"
aria-roledescription={this.ariaRoleDescNavigationList}
aria-label={this.navigationMenuPrimaryHiddenText}
>
<slot></slot>
Expand All @@ -37,7 +36,6 @@ export default function SideNavigationTemplate(this: SideNavigation) {
:
<ul role="tree"
class="ui5-sn-list ui5-sn-flexible"
aria-roledescription={this.ariaRoleDescNavigationList}
aria-label={this.navigationMenuPrimaryHiddenText}
>
<slot></slot>
Expand All @@ -58,15 +56,13 @@ export default function SideNavigationTemplate(this: SideNavigation) {
<div role="menubar"
class="ui5-sn-list ui5-sn-fixed"
aria-orientation="vertical"
aria-roledescription={this.ariaRoleDescNavigationList}
aria-label={this.navigationMenuFooterHiddenText}
>
<slot name="fixedItems"></slot>
</div>
:
<ul role="tree"
class="ui5-sn-list ui5-sn-fixed"
aria-roledescription={this.ariaRoleDescNavigationList}
aria-label={this.navigationMenuFooterHiddenText}
>
<slot name="fixedItems"></slot>
Expand Down
6 changes: 0 additions & 6 deletions packages/fiori/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,15 +548,9 @@ SEARCH_SUGGESTIONS=Suggestions
#XTXT: Text for the Side Navigation Popover hidden text
SIDE_NAVIGATION_POPOVER_HIDDEN_TEXT=Navigation

#XTXT: Aria role description for the Side Navigation collapsed List
SIDE_NAVIGATION_COLLAPSED_LIST_ARIA_ROLE_DESC=Navigation List Menu Bar

#XTXT: Aria role description for the Side Navigation collapsed List Items
SIDE_NAVIGATION_COLLAPSED_LIST_ITEMS_ARIA_ROLE_DESC=Navigation List Menu Item

#XTXT: Aria role description for the Side Navigation List
SIDE_NAVIGATION_LIST_ARIA_ROLE_DESC=Navigation List Tree

#XTXT: Aria role description for the Side Navigation List Items
SIDE_NAVIGATION_LIST_ITEMS_ARIA_ROLE_DESC=Navigation List Tree Item

Expand Down
Loading