Skip to content

fix(ui5-search): fix broken sample #14226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndeshev merged 2 commits into from
Nov 2, 2026
Merged

fix(ui5-search): fix broken sample #14226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15b77fc
fix(ui5-search): fix broken sample
ndeshev Oct 29, 2026
50d1cce
fix(ui5-search): fix broken sample
ndeshev Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions packages/website/docs/_samples/fiori/Search/Loading/sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
<ui5-search-field id="search-loading" placeholder="Search..."></ui5-search-field>
<!-- playground-fold -->
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Sample</title>
</head>
<body style="background-color: var(--sapBackgroundColor)">
<!-- playground-fold-end -->
<ui5-search-field id="search-loading" placeholder="Search..."></ui5-search-field>

<ui5-label style="margin-top: 1rem; display: block;" show-colon>Result</ui5-label>
<ui5-text id="result-text">Enter a search term and press Enter or click the search icon</ui5-text>
<ui5-label style="margin-top: 1rem; display: block;" show-colon>Result</ui5-label>
<ui5-text id="result-text">Enter a search term and press Enter or click the search icon</ui5-text>

<!-- playground-fold -->
<script type="module" src="main.js"></script>
</body>
</html>
<!-- playground-fold-end -->
2 changes: 1 addition & 1 deletion packages/website/docs/_samples/fiori/Search/Loading/sample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function App() {
const [resultText, setResultText] = useState(
"Enter a search term and press Enter or click the search icon",
);
const searchFieldRef = useRef(null);
const searchFieldRef = useRef<InstanceType<typeof SearchFieldClass>>(null);

const handleSearch = async () => {
const query = searchFieldRef.current!.value;
Expand Down
Loading