Skip to content

ui5-icon: not support decorative mode #2383

Closed

Description

@GongRichard

Describe the bug
WC icon doesn't support decorative mode.
For our cases, we don't want icon read out by screen reader.

Expected behavior
For UI5 Icon, the default property decorative is true, so it will be skipped by screen reader.
https://sapui5.hana.ondemand.com/#/api/sap.ui.core.Icon
Please also implement this attribute for WC Icon.

Context

  • UI5 Web Components version: 0.23.2
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}

Activity

  1. fifoosid commented on Oct 27, 2020

    @fifoosid
    Contributor

    Hi @GongRichard

    Could you provide the specific use case that you have. Are you using the ui5-icon as a standalone component or do you use it inside other component(like button for example)?

  2. GongRichard commented on Oct 27, 2020

    @GongRichard
    Author

    Hi @fifoosid

    I use the ui5-icon as a standalone component.

    1. Go to https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock#/goal-list
    2. click 'Skip Tour' button
    3. click more actions button on the top right of Goal Card
    4. click 'Create Activity' button
    5. select a new satus 'low'

    2020-10-27_17-40-37

  3. nnaydenow commented on Jan 12, 2021

    @nnaydenow
    Contributor

    Internal reference: 4989

  4. PetyaMarkovaBogdanova commented on Jan 25, 2021

    @PetyaMarkovaBogdanova
    Contributor

    Hi @GongRichard ,
    the UI5-Icon component in the application is not interactive, in means that it is not focusable or tabbable by the screan reader.
    I managed to reproduce the extra speech on it with Virtual PC Cursor mode "on", because of the accessibleName
    property, which attaches the "aria-label" on the HTML element of the icon.
    Do you use this property for a specific reason?

  5. added this to the 1.0.0-rc.13 milestone on Feb 1, 2021
  6. GongRichard commented on Feb 5, 2021

    @GongRichard
    Author

    Hi @PetyaMarkovaBogdanova ,

    This accessibleName property should be wrong, I will remove it later.

    Thanks,
    Richard

  7. PetyaMarkovaBogdanova commented on Feb 9, 2021

    @PetyaMarkovaBogdanova
    Contributor

    Hi @GongRichard,
    please let me know if you still experience some issue with an extra speech triggered by the ui5-icon.

    Thank you!
    Petya Bogdanova.
    (UI5 Developer)

  8. ilhan007 commented on Feb 17, 2021

    @ilhan007
    Contributor

    Hi @GongRichard I am closing the issue as a solution has been proposed.
    If you still face the issue, just comment below and we will reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions