Repository navigation
Stop EF Design and build-only pins leaking into consumer apps - #451
Merged
Merged
Conversation
Facet.Extensions.EFCore listed Microsoft.EntityFrameworkCore.Design as a package dependency (developmentDependency only applies to direct installs), so every app shipped it with its Roslyn/MSBuild closure. It is now PrivateAssets="all"; the Design/ types are only loaded by 'dotnet ef', which already requires the app to reference EFCore.Design. A minimal net8 app's output drops from 56 files / 29 MB to 19 files / 3.4 MB. The System.Collections.Immutable 10.x pins existed because Facet.Extensions compiled against the generator assembly, pulling in Roslyn's SCI; they then leaked to net8/net9 consumers of four packages. The generator project is now routed into an unconsumed item type, keeping the Facet package dependency without compiling against it, so the pins and the repo-wide MSB3277 suppression are gone (a narrow net8 suppression remains in Facet.Extensions.EFCore for EFCore.Design 8's Roslyn 4.5). The System.Security.Cryptography.Xml override is private as well, and bumped to 10.0.14: 10.0.12 and its Pkcs dependency now have high-severity advisories, and were shipped to every EFCore/EFCore.Mapping consumer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Facet.Extensions.EFCore listed Microsoft.EntityFrameworkCore.Design as a package dependency (developmentDependency only applies to direct installs), so every app shipped it with its Roslyn/MSBuild closure. It is now PrivateAssets="all"; the Design/ types are only loaded by 'dotnet ef', which already requires the app to reference EFCore.Design. A minimal net8 app's output drops from 56 files / 29 MB to 19 files / 3.4 MB.
The System.Collections.Immutable 10.x pins existed because Facet.Extensions compiled against the generator assembly, pulling in Roslyn's SCI; they then leaked to net8/net9 consumers of four packages. The generator project is now routed into an unconsumed item type, keeping the Facet package dependency without compiling against it, so the pins and the repo-wide MSB3277 suppression are gone (a narrow net8 suppression remains in Facet.Extensions.EFCore for EFCore.Design 8's Roslyn 4.5).
The System.Security.Cryptography.Xml override is private as well, and bumped to 10.0.14: 10.0.12 and its Pkcs dependency now have high-severity advisories, and were shipped to every EFCore/EFCore.Mapping consumer.