Repository navigation
Secure test workflow and protect dashboard JSON API - #450
Merged
Merged
Conversation
test.yml: drop the workflow_run trigger. It ran in the base repository's context (secrets, write token) while checking out and building the PR head commit, so fork PRs could run MSBuild code with those rights. pull_request and push already cover the same tests. Also drop the unused pull-requests: write permission and skip the check-run reporter for fork PRs, whose read-only token cannot create one. Facet.Dashboard: RequireAuthentication/AuthenticationPolicy only applied to the HTML page, so the JSON API (enabled by default) served the full source and facet model anonymously. Authorization now applies to every endpoint the dashboard maps. Adds endpoint-metadata tests that fail on the previous code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
preview.yml published a new nuget.org prerelease on every push to every same-repo PR. Those versions are permanent, and the PR's own copy of the workflow held the NuGet publishing rights. It is now workflow_dispatch only: a maintainer runs it from the default branch with a PR number, and the job publishes that open, same-repo PR's head commit. Runs from other branches are skipped, so only the default branch's workflow file can publish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test.yml: drop the workflow_run trigger. It ran in the base repository's context (secrets, write token) while checking out and building the PR head commit, so fork PRs could run MSBuild code with those rights. pull_request and push already cover the same tests. Also drop the unused pull-requests: write permission and skip the check-run reporter for fork PRs, whose read-only token cannot create one.
Facet.Dashboard: RequireAuthentication/AuthenticationPolicy only applied to the HTML page, so the JSON API (enabled by default) served the full source and facet model anonymously. Authorization now applies to every endpoint the dashboard maps. Adds endpoint-metadata tests that fail on the previous code.