Skip to content

Secure test workflow and protect dashboard JSON API - #450

Merged
Tim-Maes merged 2 commits into
masterfrom
fix/ci-and-dashboard-auth
Oct 30, 2026
Merged

Tim-Maes merged 2 commits into
masterfrom
fix/ci-and-dashboard-auth

Conversation

@Tim-Maes

Copy link
Copy Markdown
Owner

test.yml: drop the workflow_run trigger. It ran in the base repository's context (secrets, write token) while checking out and building the PR head commit, so fork PRs could run MSBuild code with those rights. pull_request and push already cover the same tests. Also drop the unused pull-requests: write permission and skip the check-run reporter for fork PRs, whose read-only token cannot create one.

Facet.Dashboard: RequireAuthentication/AuthenticationPolicy only applied to the HTML page, so the JSON API (enabled by default) served the full source and facet model anonymously. Authorization now applies to every endpoint the dashboard maps. Adds endpoint-metadata tests that fail on the previous code.

Tim-Maes and others added 2 commits October 30, 2026 09:47
test.yml: drop the workflow_run trigger. It ran in the base repository's
context (secrets, write token) while checking out and building the PR head
commit, so fork PRs could run MSBuild code with those rights. pull_request
and push already cover the same tests. Also drop the unused
pull-requests: write permission and skip the check-run reporter for fork
PRs, whose read-only token cannot create one.

Facet.Dashboard: RequireAuthentication/AuthenticationPolicy only applied
to the HTML page, so the JSON API (enabled by default) served the full
source and facet model anonymously. Authorization now applies to every
endpoint the dashboard maps. Adds endpoint-metadata tests that fail on the
previous code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
preview.yml published a new nuget.org prerelease on every push to every
same-repo PR. Those versions are permanent, and the PR's own copy of the
workflow held the NuGet publishing rights. It is now workflow_dispatch only:
a maintainer runs it from the default branch with a PR number, and the job
publishes that open, same-repo PR's head commit. Runs from other branches
are skipped, so only the default branch's workflow file can publish.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant