12_findTheOldest fix ambiguity and remove redundant test description - #428
Conversation
fix ambiguity in test description , old was 'finds the person with the greatest age if someone is still living.' remove redundant test that checks for 'finds the person with the greatest age if the OLDEST is still living' since both this and the above test for ability to check if there is no death year field.
|
These tests actually check two seperate cases. In the first case it verifies that the function returns the oldest person when there is a person still living in the set. In the second case it makes sure that the function returns the oldest person when there is a person still living in the set AND that person is still living. Why would you need both checks? Perhaps someone would write a function that simply skips living people completely and therefore misses a case. Or does not compute the living person correctly...etc. |
|
According to what I understand from you. We check for these two cases.
This means we want to check if the code in the two cases
Then I would like to change the comment to be as stated above. |
|
@donRehan just checking if you're able to make the updates as discussed in the above comment? |
|
I apologize this is my first PR didn't know how to change it, but I believe I fixed it as per our discussion now. |
12_findTheOldest fix ambiguity and remove redundant test description
12_findTheOldest fix ambiguity and remove redundant test description
12_findTheOldest fix ambiguity and remove redundant test description
12_findTheOldest fix ambiguity and remove redundant test description
12_findTheOldest fix ambiguity and remove redundant test description
fix ambiguity in test description , old was 'finds the person with the greatest age if someone is still living.'
remove redundant test that checks for 'finds the person with the greatest age if the OLDEST is still living' since both this and the above test for ability to check if there is no death year field.
Because
I had faced difficulty understanding the tests so wanted to make it easier for others to understand the test when they are learning
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder