Skip to content

build(deps): SkiaSharp 4.156.1, Uno 7 and PublicApiAnalyzers 5.6 - #300

Open
michaelstonis wants to merge 4 commits into
mainfrom
deps/skiasharp-4.156-and-analyzers
Open

michaelstonis wants to merge 4 commits into
mainfrom
deps/skiasharp-4.156-and-analyzers

Conversation

@michaelstonis

Copy link
Copy Markdown
Contributor

Supersedes #282 and #284, which fail CI.

This moves KumikoUI.Uno to Uno 7, a breaking change for Uno consumers; it needs a maintainer decision before merging.

Why the Dependabot PRs fail

  • Bump the skiasharp group with 1 update #282 (SkiaSharp 4.156.1): the new SkiaSharp raised its floors. SkiaSharp.Views.Maui.Controls needs Microsoft.Maui.Controls 10.0.110 (NU1605 against 10.0.20), SkiaSharp.Views.Uno.WinUI needs Uno.WinUI 7 (the Uno jobs were skipped on the PR, so CI never showed it), and SkiaSharp.HarfBuzz needs HarfBuzzSharp 14.4.0.101.
  • Bump the everything-else group with 3 updates #284: PublicApiAnalyzers 5.x counts compiler-generated record, record struct and delegate members as public API, so Core failed with RS0016. The group also bumps Uno.Sdk to 7.0.22.

Changes

  • SkiaSharp 4.156.1, MauiVersion 10.0.110, Uno.Sdk 7.0.22 (TypeNameCheck baseline Uno.WinUI 7.0.65), HarfBuzzSharp native assets 14.4.0.101.
  • KumikoUI.Uno.csproj: the SkiaRenderer feature is ignored in a library under Uno 7 (UNOB0030), so it uses Skia and references SkiaSharp.Views.Uno.WinUI explicitly on non-Windows heads.
  • PublicApiAnalyzers 5.6.0; Core's PublicAPI.Unshipped.txt regenerated (36 lines, no suppressions).
  • Uno sample moved to Uno 7 (Android NativeApplication / ApplicationActivity namespaces, CreateHost()), with explicit HarfBuzzSharp native references because Uno.Sdk 7.0.22 pins 14.4.0.100.
  • CONTRIBUTING toolchain table, ROADMAP and CHANGELOG (Unreleased, breaking) updated.

Verified locally (macOS arm64)

Core 3136, SkiaSharp 41, SourceGenerators 9, MAUI 336 and Uno 281 tests pass; golden images unchanged. MAUI and Uno libraries and both samples build on every Apple, Android, WebAssembly and desktop head; doc snippets build; Core and SkiaSharp tests pass in Linux arm64 Docker.

Not run: Windows heads, Native AOT jobs, the trimmed WebAssembly publish. The Uno device checks in docs/uno/verification.md were all made on Uno 6.7.

…zSharp native assets to 14.4.0.101

SkiaSharp 4.156.1 moves several dependency floors, so these bumps have to land together:

- SkiaSharp.Views.Maui.Controls requires Microsoft.Maui.Controls 10.0.110, so the explicit
  10.0.20 floor in KumikoUI.Maui was an NU1605 downgrade. MauiVersion is now 10.0.110.
- SkiaSharp.Views.Uno.WinUI requires Uno.WinUI 7.0.0-dev.2333 or later, which Uno.Sdk 6.7
  cannot provide (NU1605). Uno.Sdk moves to 7.0.22 and UnoWinUIVersion (the TypeNameCheck
  baseline) to 7.0.65, the Uno.WinUI version that SDK resolves.
- SkiaSharp.HarfBuzz depends on HarfBuzzSharp 14.4.0.101, so the Linux and WebAssembly
  native assets, which must match the managed version, move to 14.4.0.101.

Uno 7 changes:
- The SkiaRenderer feature is ignored in a library (UNOB0030). The library uses the Skia
  feature, which resolves SKCanvasElement.
- That feature no longer brings in SkiaSharp.Views.Uno.WinUI (SKXamlCanvas), so
  KumikoUI.Uno references it explicitly on every non-Windows head.

The README version references move to 4.156.1.
Version 5.x reports the members the compiler synthesizes for records, record structs
and delegates (Equals, GetHashCode, ToString, ==, !=, Deconstruct, <Clone>$, the
delegate Invoke) as public API under RS0016. They were always part of the public
surface; the old analyzer did not require them to be declared. Regenerated
KumikoUI.Core's PublicAPI.Unshipped.txt with eng/update-public-api.sh. KumikoUI.SkiaSharp,
KumikoUI.Maui and KumikoUI.Uno have no changes.
- Android: NativeApplication and ApplicationActivity moved to Uno.UI.Runtime.Android, and the
  application class now builds the host in CreateHost().
- Reference HarfBuzzSharp's native libraries at 14.4.0.101 on each head. Uno.Sdk 7.0.22 adds them
  at 14.4.0.100, but the managed HarfBuzzSharp that Uno.WinUI and SkiaSharp.HarfBuzz depend on is
  14.4.0.101 and requires matching natives (NU1605 downgrade otherwise).

Also update the pinned-toolchain table, the roadmap and the changelog for Uno.Sdk 7 and SkiaSharp 4.156.1.
…e package

Uno.Sdk 7's Skia feature adds Uno.WinUI.Composition.Skia, which the
nuspec handed on as a dependency, and it adds its uno-proguard.cfg to
every Android project, so the library packed a KumikoUI.Uno.aar. Mark
the package private like Graphics2DSK and drop the ProGuard item from
the library; app heads get both from their own Uno.Sdk.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant