Skip to content

Fix CJK IME key events on Windows - #6675

Open
happykawayigt wants to merge 1 commit into
Textualize:mainfrom
happykawayigt:fix/preserve-vk0-ime-characters
Open

Fix CJK IME key events on Windows#6675
happykawayigt wants to merge 1 commit into
Textualize:mainfrom
happykawayigt:fix/preserve-vk0-ime-characters

Conversation

@happykawayigt

Copy link
Copy Markdown

Link to issue or discussion

Fixes #6667.

Summary

  • preserve valid Unicode characters from Windows console events whose virtual-key code is zero
  • continue filtering pure modifier events that carry no Unicode character
  • add Windows-specific regression coverage for both paths

Testing

  • pytest tests/test_win32.py tests/test_xterm_parser.py -q (69 passed, 1 xfailed)
  • black --check src/textual/drivers/win32.py tests/test_win32.py
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: VK=0 filter in win32.py discards CJK IME composition events

1 participant