Skip to content

IFile.Create has different return type than File.Create #779

Closed
Closed
IFile.Create has different return type than File.Create#779
Labels
area: coreIssues that address the core abstractions & the wrappersflag: good-first-issueIssues that are good for first time contributorsstate: ready to pickIssues that are ready for being worked ontype: enhancementIssues that propose new functionality

Description

@Heldenkrieger01
Heldenkrieger01
opened on Dec 14, 2021

Describe the bug
The IFile.Create() method returns a Stream, but the "original" File.Create() returns a FileStream. This is important, because the FileStream contains the Name-property with the files name.

Expected behavior
IFile.Create() returns a FileStream.

Activity

  1. Heldenkrieger01
    added
    state: needs discussionIssues that need further discussion
    type: bugIssues that describe misbehaving functionality
    on Dec 14, 2021

  2. fgreinacher commented on Dec 17, 2021

    @fgreinacher
    fgreinacher
    on Dec 17, 2021
    Contributor

    This is more or less by design, because FileStream relies on the real file system.

    We could return a custom subclass of Stream that adds the Name property.

    What do you think about this @Heldenkrieger01?

  3. Heldenkrieger01 commented on Dec 23, 2021

    @Heldenkrieger01
    Heldenkrieger01
    on Dec 23, 2021
    Author

    That would be great, especially for people like me, that move to Abstractions with existing code.

  4. fgreinacher commented on Jan 6, 2022

    @fgreinacher
    fgreinacher
    on Jan 6, 2022
    Contributor

    Cool, so let's make this as ready and discuss details in a PR, once somebody finds the time to work on this 👍

  5. fgreinacher
    added
    area: coreIssues that address the core abstractions & the wrappers
    state: ready to pickIssues that are ready for being worked on
    type: enhancementIssues that propose new functionality
    and removed
    state: needs discussionIssues that need further discussion
    type: bugIssues that describe misbehaving functionality
    on Jan 6, 2022
  6. fgreinacher
    added
    flag: good-first-issueIssues that are good for first time contributors
    on Feb 28, 2022

  7. vbreuss commented on Apr 16, 2023

    @vbreuss
    vbreuss
    on Apr 16, 2023
    Member

    I think this issue can be closed, as the FileSystemStream was implemented in #906 ...
    Do you agree, @Heldenkrieger01 ?

  8. fgreinacher commented on Apr 19, 2023

    @fgreinacher
    fgreinacher
    on Apr 19, 2023
    Contributor

    I'm closing this. Feel free to reopen if needed!

  9. fgreinacher
    closed this as completedon Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: coreIssues that address the core abstractions & the wrappersflag: good-first-issueIssues that are good for first time contributorsstate: ready to pickIssues that are ready for being worked ontype: enhancementIssues that propose new functionality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions