TD-7596 Review and optimise SP StoreDiagScoreSCO

[sherif-olaboye]

JIRA link

https://hee-tis.atlassian.net/browse/TD-7596

Description

Redundant Subqueries:
The subquery fetches ApplicationID twice using identical logic for an OR condition ((t.OriginalTutorialID = @TutorialID) OR ... AND (t.TutorialID = @TutorialID)). This hurts performance by causing unnecessary table scans.
Inconsistent Parameter Casing:
Parameters like @progressid and @ProgressID are mixed, though SQL Server is case-insensitive by default, it's best practice to keep it clean.

Complex Join/Subquery Structure:
Updating a table via a complex derived table join can sometimes prevent SQL Server from generating an optimal execution plan. Breaking the lookup into a variable or simplifying the JOIN logic improves readability and performance.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
• Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
• Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
• Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
• Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
  Either:
• Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • doc_1_here
    Or:
• Confirmed that none of the work that I have undertaken requires any updates to documentation