Skip to content

ADS-112..117/120 Document Ads core concepts and vendors - #744

Draft
MaartenRimaux wants to merge 22 commits into
ads-docs-v2from
ADS-112-document-channels
Draft

ADS-112..117/120 Document Ads core concepts and vendors#744
MaartenRimaux wants to merge 22 commits into
ads-docs-v2from
ADS-112-document-channels

Conversation

@MaartenRimaux

@MaartenRimaux MaartenRimaux commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Combines the former stacked PRs #744#750 into a single PR on top of the ADS-110 versioning foundation, documenting the V2 core concepts and vendor integrations:

  • ads/concepts/channels.mdx (ADS-112), breaks.mdx + break lifecycle/format SVGs (ADS-113), templates.mdx (ADS-116), events.mdx (ADS-114), origins.mdx + marker-detection.mdx (ADS-115), break-manifest.mdx (ADS-120)
  • ads/vendors/index.mdx + google.mdx (ADS-117)

Sidebar changes address review feedback: "Getting started" stays first; "Core concepts" uses items: [{ type: 'autogenerated', dirName: 'concepts' }] (ordered via sidebar_position frontmatter 1–7); a new "Vendors" category autogenerates from ads/vendors.

Frozen V1 content under ads_versioned_docs/ is untouched.

Link to Devin session: https://dolby.devinenterprise.com/sessions/e8dd7ca7ec6b42c1b0e51829769e1199
Requested by: @MaartenRimaux

@MaartenRimaux MaartenRimaux self-assigned this Jul 16, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://THEOplayer.github.io/documentation/pr-preview/pr-744/

Built to branch gh-pages at 2026-07-16 14:01 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Comment thread sidebarsAds.ts Outdated
Comment thread sidebarsAds.ts
@devin-ai-integration
devin-ai-integration Bot force-pushed the ADS-112-document-channels branch from 6cc6acd to aea910c Compare July 30, 2026 14:21
@devin-ai-integration devin-ai-integration Bot changed the title ADS-112 Document Ads channels ADS-112..117/120 Document Ads core concepts and vendors Jul 30, 2026
Base automatically changed from ADS-110-ads-docs-versioning to ads-docs-v2 July 30, 2026 15:15
@MaartenRimaux
MaartenRimaux force-pushed the ADS-112-document-channels branch from 0caae3a to 35debe2 Compare July 30, 2026 15:15
@devin-ai-integration
devin-ai-integration Bot force-pushed the ADS-112-document-channels branch 2 times, most recently from 7703a59 to 35debe2 Compare July 30, 2026 15:17
devin-ai-integration Bot and others added 5 commits August 14, 2026 08:49
Co-Authored-By: maarten.rimaux <maarten.rimaux@dolby.com>
Co-Authored-By: maarten.rimaux <maarten.rimaux@dolby.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: maarten.rimaux <maarten.rimaux@dolby.com>
Co-Authored-By: maarten.rimaux <maarten.rimaux@dolby.com>
devin-ai-integration Bot and others added 11 commits August 14, 2026 08:49
Co-Authored-By: maarten.rimaux <maarten.rimaux@dolby.com>
Co-Authored-By: maarten.rimaux <maarten.rimaux@dolby.com>
Co-Authored-By: maarten.rimaux <maarten.rimaux@dolby.com>
Co-Authored-By: maarten.rimaux <maarten.rimaux@dolby.com>
…ition

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot force-pushed the ADS-112-document-channels branch from 3d2f6ec to b2c876c Compare August 14, 2026 08:49
@devin-ai-integration

Copy link
Copy Markdown
Contributor

Documentation preview for this PR is available at:

🚀 https://docs-preview.optiview.dolby.com/pr-744/

(The earlier github.io preview link is outdated — previews now deploy to CloudFront. The new preview is rebuilding after the rebase onto the updated ads-docs-v2.)

@theoplayer-bot

theoplayer-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
Documentation preview
🚀 View preview at
https://docs-preview.optiview.dolby.com/pr-744/

Deployed from commit be8d12b at 2026-08-14 15:28 UTC.

- Simplify break identity, remove stored fields and internal mechanics
- Rework scheduling: timebases, cued breaks, template snapshots, event preparation, constraints rationale
- Rename lifecycle to Break Lifecycle with customer-facing states and diagram
- Rename cue-and-punch to Break punching
- Restructure break configuration: general, event based triggers, controls, layouts, variants, asset model
- Add clickable layout overview with docs-colored visuals
- Use regional production domains and UUIDs in examples
- Align related resources tables across pages

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Reframe the page around the backend/player contract and side-loading (with a
data-flow diagram), simplify the endpoint and caching text, document the 1.1.0
envelope properties, and defer break details to the Breaks page.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Simplify the intro around vendor assets, keep the supported vendors table
without fan-out wording, and replace the Ads V2 model mapping with a related
resources section.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants