fix(blog): preserve space when back link is hidden - #1201
Merged
Conversation
Keep the back link markup on filtered list views and use visibility:hidden when PORTAL_BLOG_SHOW_BACK_LINK is false.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Filtered news list pages lost vertical space below the list after #1200 because the back link was omitted when
PORTAL_BLOG_SHOW_BACK_LINKis false. The markup stays in place and is hidden withvisibility: hiddenso layout matches the previous back link spacing.Related
Changes
post_list.htmlto always render.blog-backon author, archive, and tag views when the setting is falseTesting
PORTAL_BLOG_SHOW_BACK_LINK, open a filtered news list URL.PORTAL_BLOG_SHOW_BACK_LINK = Trueand confirm the link is visible.UI