fix(settings): restore custom_app_settings for v4.40 rollout - #1198
Merged
Conversation
#1177 need not break all clients. Less urgent solution is restoring this code to support both custom app settings locations.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Restore
custom_app_settings.pysupport.Related
Changes
taccsite_cms.custom_app_settings(CUSTOM_APPS,STATICFILES_DIRS,CUSTOM_MIDDLEWARE) aftersettings_localTesting
If you really want to test working code that I merely restored…
custom_app_settings.pywithCUSTOM_APPS(e.g. blog stack) attaccsite_cms/custom_app_settings.pyas Camino does onmain.INSTALLED_APPS.settings_custom.pywithEXTRA_INSTALLED_APPSonly (nocustom_app_settings) and confirm CMS starts and apps load.EXTRA_*keys are present.UI
N/A