feat(cms): add all Bootstrap 4 alert color choices - #1195
Merged
Conversation
Closes WP-1297 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR Summary by QodoExpose full Bootstrap 4 alert context variants in CMS plugin
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Jul 2, 2026
## Overview Bootstrap alert links uncolored. ## Related - [WP-1297](https://tacc-main.atlassian.net/browse/WP-1297) - TACC/Core-CMS#1195 ## Changes - **updated** `.alert .alert-link` selector to match Bootstrap specificity - **updated** link color from `unset` to `var(--global-color-accent--light)` ## Testing 1. `npm run build:css` 2. `npm start` 3. Open http://localhost:3000/components/preview/alert 4. Verify section-scoped alert links are blue (`var(--global-color-accent--light)`). 5. Verify `alert-primary` link remains white (inherits from scope-global). ## UI <img width="1600" height="1500" alt="image-1783032964204" src="https://github.com/user-attachments/assets/78ff1085-db50-4199-a8c1-6ceba05ba884" /> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…n-nav) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
wesleyboar
added a commit
that referenced
this pull request
Jul 3, 2026
## Overview **Child** `test/*` pages (Sections, Cards, Alerts) now appear in the site navigation by default. **Parent** `/test/` page remains hidden. ## Related - requires #1195 ## Changes - **updated** `in_navigation` from `False` to `True` ## Testing 1. `make start` 2. Run any `create_test_page_*` command with `--replace`. 3. Verify the test page appears in the site nav but `/test/` itself does not. ## UI Skipped. Tested, though. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Merged
wesleyboar
added a commit
that referenced
this pull request
Jul 3, 2026
## Overview 1. Offer color to buttons of style success, warning, and danger. 2. Offer command to create test page. ## Related Minimal solution to gotcha introduced by #1195. ## Changes - **updates** @tacc/core-styles - **adds** `manage.py` command to create test page ## Testing 1. Create page. 2. Add buttons of various types. ``` docker exec core_cms python manage.py create_test_page_button_style --replace ``` 3. Review buttons use and reuse blue, gray, and white. ## UI <img width="780" height="460" alt="Screenshot 2026-07-02 at 22 57 46" src="https://github.com/user-attachments/assets/dcff9529-6192-44dc-9bae-c45ae79aa57e" /> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Exposes all Bootstrap 4 alert context variants (
success,danger,warning,info) in the CMS Bootstrap Alert plugin. Previously onlyprimary,secondary,light, anddarkwere available.Warning
Offer these new Styles for Buttons also, but they have no effect, cuz buttons set "tertiary" colors for all of these Styles.
Related
Changes
success,danger,warning,infotoDJANGOCMS_BOOTSTRAP4_COLOR_STYLE_CHOICEScreate_test_page_alert_stylemanagement command (all 8 context variants)Testing
make startdocker exec core_cms python manage.py create_test_page_alert_style --replaceUI