chore(cms): label footer-content in Structure sidebar - #1188
Merged
Conversation
Shows a friendly name for the existing footer static placeholder in CMS Structure mode.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
wesleyboar
added a commit
that referenced
this pull request
Jun 19, 2026
## Overview Stacks on #1083. Drops the extra ContentRenderer path and duplicate settings template; `header.html` owns the static placeholder, `header_logo.html` stays settings markup as on `main`. ## Related - requires #1083 - footer Structure label: #1188 (merged to `main`) - static-placeholder perm: #1187 (merged to `main`) ## Changes - **deleted** `render.py`, `constants.py`, `header_tags`, and `header_logo_via_settings.html` - **updated** `header.html`: `{% static_placeholder "header-logo" or %}` → `header_logo.html` - **updated** `CMS_PLACEHOLDER_CONF` for `header-logo` (keeps `footer-content` with #1188) - **updated** `docs/gh-999-editable-header-plan.md` (minimal deltas) ## Testing Same as #1083 steps 1–4 after this branch is merged into `feat/GH-999-let-cms-admin-edit-header`. ## UI No new UI; structure only.
wesleyboar
added a commit
that referenced
this pull request
Jul 14, 2026
## Overview Two rc9 changes were missed in the v4.40.0-rc10 smoke-test doc because their commit messages under-described what they actually did (`test: Button styles`, `chore(cms): label footer-content`) — both are portal-testable. ## Related - #1197 - #1188 ## Changes - **added** "Bootstrap Button Colors" section: `success`/`warning`/`danger` button styles, which always render blue/gray/white (#1197) - **added** "Footer Static Placeholder Label" section: Structure mode shows "Footer content" instead of raw code (#1188) ## Testing 1. Read `docs/test-releases/v4.40.0-rc10.md` on the branch. 2. Confirm the new sections' steps match #1197 and #1188. ## UI N/A (documentation only). --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The footer already uses the
footer-contentstatic placeholder; this adds a display name so Structure mode shows “Footer content” instead of the raw code.Related
Changes
CMS_PLACEHOLDER_CONFwith afooter-contententry and translated name onlyTesting
make start, log in as a user who can use Structure mode.UI
Structure sidebar label only; no front-end markup change.