feat(picture): fall back to image default caption - #1182
Merged
Conversation
When a Picture plugin has no instance-specific caption content (neither caption_text nor child plugins), render the filer Image's default_caption in the <figcaption>, mirroring the existing default_alt_text fallback for the alt attribute and the blog template's use of default_caption. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A Picture plugin only showed a caption when the editor typed one into the plugin. This falls back to the filer Image's own default caption when no instance-specific caption is set, so a shared image carries its caption everywhere without re-entering it — matching how
altalready falls back to the image's default alt text.Changes
default_captionfallback inpicture.html: the<figure>/<figcaption>now render the image's default caption when there is nocaption_textand no child pluginstaccsite_cms/tests/djangocms_picture_default_caption.py)Testing
make start<figcaption>shows the default caption.docker exec core_cms python manage.py test taccsite_cms.tests.djangocms_picture_default_caption --no-inputUI
default.caption.works.mov
Notes
Tip
I also tested instance caption (with a default) and instance caption (with no default); both resulted in the instance caption being added under image.