Skip to content

fix: empty article visual is visible when editing - #1166

Merged
wesleyboar merged 1 commit into
mainfrom
fix/empty-article-visual-is-visible-when-editing
May 28, 2026
Merged

fix: empty article visual is visible when editing#1166
wesleyboar merged 1 commit into
mainfrom
fix/empty-article-visual-is-visible-when-editing

Conversation

@wesleyboar

@wesleyboar wesleyboar commented May 28, 2026

Copy link
Copy Markdown
Member

Overview

Integrate tested bandaid from TACC/Core-CMS-Custom@af34eeeb.

If user is editing a news article that has no content in media placeholder for an article, the margin of the parent element has unwanted margin. (The parent element is visible, because it has CMS-generated markup, thus has content, so is not hidden by existing CSS.)

Related

Changes

  • added editor-specific selector to existing display: none rule

Testing

  1. Have a CMS with news.
  2. News config allows post and media content (default)
  3. Article has no image.
  4. User is both logged in and in ?edit mode.
  5. Verify .blog-visual is hidden (display: none).

UI

While Editing
Before After
editing, before editing, after
Not Editing (Unchanged)
Before & After
not editing

@wesleyboar
wesleyboar marked this pull request as ready for review May 28, 2026 16:03
@wesleyboar
wesleyboar merged commit dd90566 into main May 28, 2026
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@wesleyboar
wesleyboar deleted the fix/empty-article-visual-is-visible-when-editing branch May 28, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant