fix(ckeditor): WYSWIYGs broken (because race condition) - #1164
Merged
Conversation
stylesSet loads during editor init, after extraPlugins are resolved, so addExternal had no effect on remote servers. customConfig loads first, before plugin resolution, which is the correct place for it. Co-authored-by: Cursor <cursoragent@cursor.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This was referenced May 28, 2026
wesleyboar
changed the title
wesleyboar
added a commit
that referenced
this pull request
May 28, 2026
## Overview Moves the Google Docs paste handler (bold/italic span → `<strong>`/`<em>`) from `ckeditor.wysiwyg.js` into `ckeditor.config.js`. The wysiwyg file is for style definitions only; JS behavior belongs in the config file. ## Related - follow-up to #1164 ## Changes - **moved** paste handler from `ckeditor.wysiwyg.js` to `ckeditor.config.js` ## Testing 1. Deploy with #1164 merged. 2. Open a text plugin (WYSIWYG) in edit mode. 3. Paste content from Google Docs with bold and italic text. 4. Verify bold renders as `<strong>` and italic as `<em>`. ## UI https://github.com/user-attachments/assets/73825a6e-6a48-4ddf-b951-c6f96cd168e5 --- Made with [Cursor](https://cursor.com) --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes CKEditor failing to open on remote servers after #1161.
The
pastefromgdocsplugin registered viaextraPluginswas returning 404 becauseaddExternal(which redirects CKEditor to the CDN) was placed in thestylesSetfile. That file loads during editor initialization, afterextraPluginsare already resolved — so the redirect never took effect on prod/pre-prod.Moving
addExternalto a dedicatedcustomConfigfile fixes this: CKEditor loadscustomConfigfirst, before plugin resolution.Related
Changes
ckeditor.config.js— new CKEditorcustomConfigfile; holdsaddExternalfor CDN plugindjangocms_plugins.py— registercustomConfigaddExternalfromckeditor.wysiwyg.js(wrong timing; now in config file)Testing
pastefromgdocs.UI
works.on.remote.server.mov
Made with Cursor