fix(css): remove dead figcaption offset style - #1158
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
news-article-page__media--offset__figcaptionappliedpadding-right: 125pxto.figure .figure-captionbut:Related
Changes
news-article-page__media--offset__figcaptionmixinTesting
No visible change expected — the selector never matched reachable markup.
UI
N/A
Notes
The selector
&.figure .figure-captionrequires an element to simultaneously carry a CMS align class (.align-right/.align-left) and Bootstrap's.figureclass, with a.figure-captiondescendant. This combination cannot be produced through the Text plugin, which is how article body content is authored. Older Texascale editions that did use Bootstrap figures predated this code. Newer websites work exclusively inside the Text plugin, which cannot produce Bootstrap figure markup. The original???:comment in the mixin already signaled uncertainty about whether it ever applied. And if the code appeared, it would have unwanted padding because of this code (I tested manually).Made with Cursor.
Footnotes
Seems to be cruft from older version of Texascale. I reproduced the style in Core-CMS, where it looks like a bug. New and old Texascale don't have markup that will be affected by this change. ↩