build: more agent env setup improvements by wesleyboar · Pull Request #1109 · TACC/Core-CMS

wesleyboar · 2026-03-05T23:34:55Z

Overview

Resolve issues encountered while setting up dev env

Changes

docker-compose.dev.yml: updated Elasticsearch image from 7.17.0 to 7.17.9
AGENTS.md: noted discovered gotchas

Testing

DJANGO_SUPERUSER_PASSWORD=admin123 make setup
Verify all Docker containers are running.
Confirm CMS running at localhost:8000.
Verify Elasticsearch cluster health is green at localhost:9201/_cluster/health.
(Optional) docker exec core_cms flake8 taccsite_cms/ --max-line-length=120 (332 pre-existing warnings expected).
(Optional) docker exec core_cms python manage.py test taccsite_cms.contrib.taccsite_sample --no-input (6 tests passed).
(Manual) Log in as admin, create a "Hello World" CMS page, and edit page.

UI

Verified. Not posted.

- Dockerfile: Pin uwsgi==2.0.23 and set PIP_NO_BUILD_ISOLATION=1 to fix Poetry PEP 517 build failure - docker-compose.dev.yml: Update ES image from 7.17.0 to 7.17.9 to fix cgroups v2 crash - AGENTS.md: Document discovered gotchas (ES cgroup, uwsgi build, postgres secrets) Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>

Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>

…LATION) Build succeeds without these changes; the initial failure was transient. Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>

qodo-code-review · 2026-03-05T23:35:06Z

Review Summary by Qodo

Fix Elasticsearch cgroups v2 crash and document dev gotchas

🐞 Bug fix 📝 Documentation

Walkthroughs

Description

• Update Elasticsearch image to 7.17.9 to fix cgroups v2 crash
• Document Elasticsearch cgroups v2 compatibility issue
• Document optional Postgres secret files for development

Diagram

flowchart LR
  ES["Elasticsearch 7.17.0<br/>crashes on cgroups v2"]
  FIX["Update to 7.17.9"]
  DOCS["Document gotchas<br/>in AGENTS.md"]
  ES -- "fix kernel issue" --> FIX
  FIX --> DOCS
  DOCS -- "includes postgres secrets" --> DOCS

File Changes

1. docker-compose.dev.yml 🐞 Bug fix +1/-1

Upgrade Elasticsearch to fix cgroups v2 crash
• Update Elasticsearch image from 7.17.0 to 7.17.9
• Resolves cgroups v2 compatibility issue causing crashes
docker-compose.dev.yml

2. AGENTS.md 📝 Documentation +2/-0

Document Elasticsearch and Postgres development gotchas

• Document Elasticsearch 7.17.0 cgroups v2 crash issue
• Note that Postgres secret files are optional for development
• Provide guidance on using ES 7.17.9+ in docker-compose.dev.yml

AGENTS.md

qodo-code-review · 2026-03-05T23:35:07Z

Code Review by Qodo

🐞 Bugs (4) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. ~~Postgres secrets note wrong~~ ☑ 🐞 Bug ⛯ Reliability

Description

AGENTS.md claims the Postgres ./conf/postgres/*.secret files can be ignored, but
docker-compose.dev.yml bind-mounts them from gitignored paths and the setup flow doesn’t create
them, so fresh setups are prone to failing or requiring manual local files.

Code

AGENTS.md[41]

+- **Postgres secret files:** `docker-compose.dev.yml` mounts `./conf/postgres/*.secret` files. These are not required for development and can be ignored.

Evidence

The new guidance says the secret files can be ignored, but the dev compose requires those host paths
to exist via bind mounts. Those files are explicitly gitignored (so they won’t be present on a fresh
clone) and the setup script starts Docker without creating them, making setup brittle and
contradicting the doc change.

AGENTS.md[35-41]
docker-compose.dev.yml[15-26]
.gitignore[37-38]
bin/setup-cms.sh[118-123]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`AGENTS.md` says Postgres `./conf/postgres/*.secret` files “can be ignored”, but `docker-compose.dev.yml` bind-mounts them from gitignored paths and `bin/setup-cms.sh` doesn’t create them. This contradiction makes first-time setup brittle.
## Issue Context
- The secret files are gitignored, so new clones won’t have them.
- The dev compose currently bind-mounts them anyway.
## Fix Focus Areas
- docker-compose.dev.yml[22-26]
- docker-compose.example-cms.yml[22-26]
- bin/setup-cms.sh[118-123]
- AGENTS.md[40-41]
- .gitignore[37-38]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. ~~Postgres secrets note wrong~~ ☑ 🐞 Bug ⛯ Reliability

Description

AGENTS.md claims the Postgres ./conf/postgres/*.secret files can be ignored, but
docker-compose.dev.yml bind-mounts them from gitignored paths and the setup flow doesn’t create
them, so fresh setups are prone to failing or requiring manual local files.

Code

AGENTS.md[41]

+- **Postgres secret files:** `docker-compose.dev.yml` mounts `./conf/postgres/*.secret` files. These are not required for development and can be ignored.

Evidence

The new guidance says the secret files can be ignored, but the dev compose requires those host paths
to exist via bind mounts. Those files are explicitly gitignored (so they won’t be present on a fresh
clone) and the setup script starts Docker without creating them, making setup brittle and
contradicting the doc change.

AGENTS.md[35-41]
docker-compose.dev.yml[15-26]
.gitignore[37-38]
bin/setup-cms.sh[118-123]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`AGENTS.md` says Postgres `./conf/postgres/*.secret` files “can be ignored”, but `docker-compose.dev.yml` bind-mounts them from gitignored paths and `bin/setup-cms.sh` doesn’t create them. This contradiction makes first-time setup brittle.
## Issue Context
- The secret files are gitignored, so new clones won’t have them.
- The dev compose currently bind-mounts them anyway.
## Fix Focus Areas
- docker-compose.dev.yml[22-26]
- docker-compose.example-cms.yml[22-26]
- bin/setup-cms.sh[118-123]
- AGENTS.md[40-41]
- .gitignore[37-38]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. ~~ES version mismatch~~ ☑ 🐞 Bug ⛯ Reliability

Description

The dev compose was bumped to Elasticsearch 7.17.9 for the cgroups v2 crash, but the example compose
path (make example) still pins 7.17.0, so users following the example workflow can still hit the
same crash.

Code

docker-compose.dev.yml[33]

+    image: docker.elastic.co/elasticsearch/elasticsearch:7.17.9

Evidence
AGENTS.md documents that ES 7.17.0 crashes on cgroups v2 and recommends 7.17.9+, and the PR updates
docker-compose.dev.yml accordingly. However, the example compose stack still pins 7.17.0 and `make
example` uses that stack, leaving a common entrypoint vulnerable to the same crash.
AGENTS.md[39-41]
docker-compose.dev.yml[32-34]
docker-compose.example-cms.yml[32-34]
docker-compose.example.yml[21-24]
Makefile[27-30]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`docker-compose.dev.yml` was upgraded to ES 7.17.9 to avoid the documented cgroups v2 crash, but `docker-compose.example-cms.yml` (used by `make example`) still pins 7.17.0.
## Issue Context
`make example` uses `docker-compose.example.yml`, which extends `docker-compose.example-cms.yml` for the Elasticsearch service.
## Fix Focus Areas
- docker-compose.example-cms.yml[32-34]
- docker-compose.example.yml[21-24]
- Makefile[27-30]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

4. ~~ES version mismatch~~ ☑ 🐞 Bug ⛯ Reliability

Description

The dev compose was bumped to Elasticsearch 7.17.9 for the cgroups v2 crash, but the example compose
path (make example) still pins 7.17.0, so users following the example workflow can still hit the
same crash.

Code

docker-compose.dev.yml[33]

+    image: docker.elastic.co/elasticsearch/elasticsearch:7.17.9

Evidence
AGENTS.md documents that ES 7.17.0 crashes on cgroups v2 and recommends 7.17.9+, and the PR updates
docker-compose.dev.yml accordingly. However, the example compose stack still pins 7.17.0 and `make
example` uses that stack, leaving a common entrypoint vulnerable to the same crash.
AGENTS.md[39-41]
docker-compose.dev.yml[32-34]
docker-compose.example-cms.yml[32-34]
docker-compose.example.yml[21-24]
Makefile[27-30]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`docker-compose.dev.yml` was upgraded to ES 7.17.9 to avoid the documented cgroups v2 crash, but `docker-compose.example-cms.yml` (used by `make example`) still pins 7.17.0.
## Issue Context
`make example` uses `docker-compose.example.yml`, which extends `docker-compose.example-cms.yml` for the Elasticsearch service.
## Fix Focus Areas
- docker-compose.example-cms.yml[32-34]
- docker-compose.example.yml[21-24]
- Makefile[27-30]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

This change avoids missing files created as empty dirs.

This reverts commit 2bd795a.

Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>

wesleyboar · 2026-03-05T23:52:07Z

/review

qodo-code-review · 2026-03-05T23:52:14Z

Persistent review updated to latest commit 67b690c

wesleyboar · 2026-03-06T00:10:20Z

Qodo is hallucinating. All is well. No more 7.17.0 references. All are 7.17.9.

This half-reverts commit d146f57. Do not update Elasticsearch for humans.

@jarosenb

## Overview Do **not** let A.I. agent environment tweaks affect other environments. ## Related - refactors #1109 - matches ElasticSearch used by [TACC/Core-Portal@v3.19.0](https://github.com/TACC/Core-Portal/blob/v3.19.0/server/conf/docker/docker-compose-dev.all.debug.yml#L35) - ~~fixes [WC-428]~~ ## Changes - **ignores** `docker-compose.agent.yml` - **documents** that AI should use `docker-compose.agent.yml` as necessary ## Testing Skipped. ## UI N/A ## Notes Initially, this PR was to solve [WC-428], but @jarosenb assures me that [the real issue (private)](https://tacc-team.slack.com/archives/C04TQ1P04UX/p1774373248637889?thread_ts=1774367163.360269&cid=C04TQ1P04UX) is unrelated to this. But, I still would have preferred this solution to #1109, so I'm tempted to merge it. [WC-428]: https://tacc-main.atlassian.net/browse/WC-428

cursoragent and others added 3 commits March 5, 2026 22:32

Ignore postgres secret files; they are not required for dev

f40c1ef

Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>

Revert unnecessary Dockerfile changes (uwsgi pin and PIP_NO_BUILD_ISO…

f7ec479

…LATION) Build succeeds without these changes; the initial failure was transient. Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>

wesleyboar mentioned this pull request Mar 5, 2026

Development environment setup wesleyboar/Core-CMS#3

Closed

wesleyboar changed the title ~~Cursor/development environment setup d0e8~~ build: more agent env setup improvements Mar 5, 2026

qodo-code-review Bot reviewed Mar 5, 2026

View reviewed changes

Comment thread AGENTS.md

wesleyboar commented Mar 5, 2026

View reviewed changes

Comment thread docker-compose.dev.yml

wesleyboar and others added 3 commits March 5, 2026 17:39

chore: mount directory, not individual optional files

2bd795a

This change avoids missing files created as empty dirs.

Revert "chore: mount directory, not individual optional files"

6ff7ffd

This reverts commit 2bd795a.

build: update ES image to 7.17.9 in docker-compose.example-cms.yml

67b690c

Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>

wesleyboar merged commit d146f57 into TACC:main Mar 6, 2026

wesleyboar deleted the cursor/development-environment-setup-d0e8 branch March 6, 2026 00:10

wesleyboar added a commit that referenced this pull request Mar 24, 2026

Refactor #1109

25f0119

This half-reverts commit d146f57. Do not update Elasticsearch for humans.

wesleyboar mentioned this pull request Mar 24, 2026

refactor(#1109): agent env setup should not affect other envs #1128

Merged

Navigation Menu

Uh oh!

build: more agent env setup improvements - #1109

build: more agent env setup improvements#1109
wesleyboar merged 6 commits into
TACC:mainfrom
wesleyboar:cursor/development-environment-setup-d0e8

wesleyboar commented Mar 5, 2026 •

edited

Loading

Uh oh!

qodo-code-review Bot commented Mar 5, 2026

Uh oh!

qodo-code-review Bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

wesleyboar commented Mar 5, 2026

Uh oh!

qodo-code-review Bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

wesleyboar commented Mar 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wesleyboar commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Related

Changes

Testing

UI

Uh oh!

qodo-code-review Bot commented Mar 5, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-code-review Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Uh oh!

Uh oh!

wesleyboar commented Mar 5, 2026

Uh oh!

qodo-code-review Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wesleyboar commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wesleyboar commented Mar 5, 2026 •

edited

Loading

qodo-code-review Bot commented Mar 5, 2026 •

edited

Loading

qodo-code-review Bot commented Mar 5, 2026 •

edited

Loading

wesleyboar commented Mar 6, 2026 •

edited

Loading