test: make retry observation waits terminal-aware - #641
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up for the retry-liveness flake tracked in #387.
#637 already landed the root-cause isolation for
SharpLinkClientRetryBehaviorTests.IdempotentUnaryShouldRetryRemoteUnavailableAndExposeResponseObservationby removing the unrelated one-second System request timeout from this response-observation/retry-policy test.This PR closes the remaining diagnostic/liveness gap in the same test:
WaitForSentPacket(Request)calls;The test still requires both the first Request and the retry Request to be emitted before injecting the successful second-attempt response. No retry, deadline, transport, or production behavior is weakened.
Validation
devand changes onlytest/SharpLink.UnitTests/Client/SharpLinkClientRetryBehaviorTests.cs.Refs #387
Follow-up to #637