Repository navigation
ci: point workflow triggers at main instead of master - #27
Merged
Merged
Conversation
The default branch was renamed master -> main, but three workflows still filtered on master and so stopped firing: - deploy-scrum.yml: push was its only automatic trigger, so the Scrum environment had not auto-deployed since the rename. - codeql.yml: push and pull_request scanning were dead; only the weekly cron still ran. - security-audit.yml: per-PR NuGet audit was dead; cron and manual dispatch still ran. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…mb/fix-master-branch-triggers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default branch was renamed
master→main, but three workflows still filter onmaster. Since nomasterbranch exists (origin/HEAD -> origin/main), those triggers have been silently dead.deploy-scrum.ymlpushworkflow_dispatchonlycodeql.ymlpush,pull_request0 6 * * 1)security-audit.ymlpull_request0 7 * * 1),workflow_dispatchdeploy-scrum.ymlis the significant one:pushwas its only automatic trigger and it has noschedulefallback, so the Scrum environment has not auto-deployed since the rename.For the other two the weekly cron kept running, so scanning was never fully blind — but PRs got no CodeQL diff alerts and no per-PR NuGet audit, and CodeQL alert state only refreshed weekly instead of per-merge.
Change
Four lines,
master→main. No other edits.pull_request.ymlandsonarqube.ymlwere already onmain; this brings the remaining three in line.Heads-up before merging
This re-arms the Scrum deploy on every push to
main— migrate, seed, then deploy toapp-awapi-scrum-centralus-03. That is what the workflow was written to do, but it hasn't fired in a while, so the first run will apply whatever migrations have accumulated since the rename. Worth watching that run.Verification
grep -rn master .github/workflows/→ no matches.mainrequires onlybuild / build(frompull_request.yml), so no required check was blocked by this and none changes here.🤖 Generated with Claude Code