Repository navigation
fix: support 16 KB page alignment for Android binary patches - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcodepush-binarypatch.sowas built with 4 KB ELF alignment, causing the Android release AAB to fail Google Play's 16 KB page size compatibility check. This change enables 16 KB alignment when building with NDK r27.Verified with NDK 27.1.12297006: arm64-v8a, x86_64, armeabi-v7a, and x86 builds pass, with all LOAD segments and RELRO end addresses aligned to 16 KB. The original 4 KB alignment was reproduced on arm64. The app AAB still needs to be rebuilt and tested on a 16 KB device.