Book Text Utils

[jcxldn]

14/2/21 | JCX's To-Do List*

• Split gradle changes? (eg. javadoc stuffs)
• Split OnHold annotation (master?)
• Address minor review requests
• Split UtilityClass annotations for unaffected files?

[codecov]

Codecov Report

Merging #72 (4003bae) into master (6392053) will increase coverage by 2.87%.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
+ Coverage     20.31%   23.19%   +2.87%     
- Complexity      133      181      +48     
============================================
  Files            71       73       +2     
  Lines          3012     3126     +114     
  Branches        402      426      +24     
============================================
+ Hits            612      725     +113     
+ Misses         2379     2355      -24     
- Partials         21       46      +25     

Impacted Files	Coverage Δ	Complexity Δ
...umbdogdiner/stickyapi/common/util/url/URLPair.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...m/dumbdogdiner/stickyapi/common/util/TextUtil.java	30.30% <28.12%> (+30.30%)	5.00 <5.00> (+5.00)
...ner/stickyapi/bukkit/item/BookAndQuillBuilder.java	28.57% <28.57%> (ø)	6.00 <6.00> (?)
...iner/stickyapi/bukkit/item/WrittenBookBuilder.java	33.87% <33.87%> (ø)	7.00 <7.00> (?)
...m/dumbdogdiner/stickyapi/common/util/MathUtil.java	25.00% <40.00%> (+11.20%)	7.00 <3.00> (+3.00)
...dumbdogdiner/stickyapi/common/util/StringUtil.java	94.93% <83.33%> (-1.79%)	36.00 <6.00> (+7.00)	⬇️
...bdogdiner/stickyapi/common/nbt/NbtJsonAdapter.java	12.50% <0.00%> (+12.50%)	1.00% <0.00%> (+1.00%)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6392053...4003bae. Read the comment docs.

[jcxldn]

LGTM

[aakatz3]

Make sure it compiles, I need to copy in the download task too

…

On Sun, Feb 14, 2021, 7:26 AM James Cahill ***@***.***> wrote: ***@***.**** commented on this pull request. LGTM — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFUCWUQ6ELXA4ZCAFISBKDS67MPVANCNFSM4WF5ZOIQ> .