Skip to content

Patch MemoryOwnerExtensions to workaround #987 - #991

Merged
JimBobSquarePants merged 1 commit into
masterfrom
af/patch-987
Aug 28, 2019
Merged

JimBobSquarePants merged 1 commit into
masterfrom
af/patch-987

Conversation

@antonfirsov

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

See this issue comment for explanation. May workaround #987 for (some? all?) users.

@antonfirsov antonfirsov changed the title Patch MemoryOwnerExtensions to fix #987 Patch MemoryOwnerExtensions to workaround #987 Aug 27, 2019
@Sergio0694

Sergio0694 commented Aug 28, 2019 •

Copy link
Copy Markdown
Member

@antonfirsov The CI just hung itself again on .NET 626 32bit with the usual out of memory error, just trigger the build again when you have some time 👍

@JimBobSquarePants

Copy link
Copy Markdown
Member

@Sergio0694 I've given it a kick.

@codecov

codecov Bot commented Aug 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #991 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
- Coverage   89.74%   89.63%   -0.12%     
==========================================
  Files        1098     1098              
  Lines       48690    48690              
  Branches     3433     3433              
==========================================
- Hits        43698    43643      -55     
- Misses       4288     4293       +5     
- Partials      704      754      +50
Impacted Files Coverage Δ
src/ImageSharp/Memory/MemoryOwnerExtensions.cs 85.71% <ø> (ø) ⬆️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.9% <0%> (-10.1%) ⬇️
...olorSpaces/Conversion/ColorSpaceConverter.Adapt.cs 60% <0%> (-8.58%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 87.64% <0%> (-6.75%) ⬇️
src/ImageSharp/Primitives/ValueSize.cs 78.94% <0%> (-5.27%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
....Tests/TestUtilities/Tests/TestEnvironmentTests.cs 63.63% <0%> (-4.55%) ⬇️
...p/Processing/Processors/Dithering/ErrorDiffuser.cs 93.75% <0%> (-3.13%) ⬇️
...ocessors/Transforms/AutoOrientProcessor{TPixel}.cs 82.35% <0%> (-2.95%) ⬇️
...ormats/Jpeg/Components/Decoder/QualityEvaluator.cs 94.04% <0%> (-2.39%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d1f1b...9f93b09. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Aug 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #991 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
- Coverage   89.74%   89.63%   -0.12%     
==========================================
  Files        1098     1098              
  Lines       48690    48690              
  Branches     3433     3433              
==========================================
- Hits        43698    43643      -55     
- Misses       4288     4293       +5     
- Partials      704      754      +50
Impacted Files Coverage Δ
src/ImageSharp/Memory/MemoryOwnerExtensions.cs 85.71% <ø> (ø) ⬆️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.9% <0%> (-10.1%) ⬇️
...olorSpaces/Conversion/ColorSpaceConverter.Adapt.cs 60% <0%> (-8.58%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 87.64% <0%> (-6.75%) ⬇️
src/ImageSharp/Primitives/ValueSize.cs 78.94% <0%> (-5.27%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
....Tests/TestUtilities/Tests/TestEnvironmentTests.cs 63.63% <0%> (-4.55%) ⬇️
...p/Processing/Processors/Dithering/ErrorDiffuser.cs 93.75% <0%> (-3.13%) ⬇️
...ocessors/Transforms/AutoOrientProcessor{TPixel}.cs 82.35% <0%> (-2.95%) ⬇️
...ormats/Jpeg/Components/Decoder/QualityEvaluator.cs 94.04% <0%> (-2.39%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d1f1b...9f93b09. Read the comment docs.

@JimBobSquarePants
JimBobSquarePants merged commit 0cda174 into master Aug 28, 2019
@JimBobSquarePants
JimBobSquarePants deleted the af/patch-987 branch August 28, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants