Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
iOS labels app-state events with a screen name only through automatic visible view controller class name capture. There was no way to set the label manually.
Summary
Adds
-[Sift setTitle:].setTitle:@"Checkout"sets a label that every later app-state collection carries inwindow_root_view_controller_titles: periodic, app-became-active, navigation andcollect. It overrides the auto-detected view controller class name.setTitle:nilresets it, so the per-event / navigation title is used again. Empty strings and non-strings (e.g.NSNullfrom a bridge) also reset.setTitle:doesn't collect. Callcollectto send an event right away.atomic, copyproperty (manualLabel) onSiftIosAppStateCollector, so it's safe to call from any thread and is visible to the next collection immediately. Kept in memory, not archived.setTitle:. Event payloads are the same as before.Testing
window_root_view_controller_titles:testSetManualTitleDoesNotCollecttestManualTitleIsUsedByLaterCollectionstestManualTitleSurvivesAutomaticNavigationTitletestAutomaticNavigationTitleDoesNotPersisttestManualTitleInBackgroundtestNilResetsManualTitletestManualTitleEmptyOrNonStringResetsSiftTests.testSetTitleIsUsedByLaterCollectionsChecklist