Repository navigation
Send the initial pane size when NAWS negotiation completes - #46
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe Telnet session now registers protocol plugins explicitly and routes window-size requests through `WindowSizeProtocol. The protocol retains the latest dimensions and reports them when NAWS negotiation and reporting settings allow. ChangesNAWS window-size reporting
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 4 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: sending the initial pane size when NAWS negotiation completes. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharpMUTerm could cache its initial pane size as sent before the server's DO NAWS arrived. TNC correctly skipped the premature subnegotiation, leaving SharpMUSH's width at its 78-column fallback until a resize.
Retain the latest dimensions in a NAWS plugin and send them from TNC's negotiation-completion callback. Serialize reports, skip duplicates, and resend after DONT/DO even when the dimensions are unchanged. TNC continues to own binary framing and IAC escaping. The explicit plugin list preserves the existing default protocols and callbacks.
Validation: reproduced the failure before the fix; all 3,134 tests across Core, Tui, Graphics, Scripting, and Web pass. Full Release build, changed-file whitespace verification, and headless snapshot smoke pass. Build reports existing ImageSharp vulnerability warnings. Independent code review found no actionable issues.
Summary by CodeRabbit