Skip to content

Run NuGet release publishing from the package output directory - #719

Merged
Shane32 merged 2 commits into
masterfrom
fix-release-package-paths
Nov 19, 2026
Merged

Shane32 merged 2 commits into
masterfrom
fix-release-package-paths

Conversation

@Shane32

@Shane32 Shane32 commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

The v1.9.0 release run built both packages and authenticated to NuGet.org successfully, then failed with File does not exist (out/*.nupkg).

Set the publish step's working-directory to out and run dotnet nuget push "*.nupkg", avoiding a directory separator in the package pattern. The final workflow change is one added setting and one changed command.

Validation: actionlint v1.7.12 and git diff --check passed. Tested the same wildcard command from the output directory against a temporary local NuGet feed; both smoke packages were pushed successfully. No external packages were published during validation.

The existing v1.9.0 run retains its original tagged workflow when rerun. Its built packages remain available for manual recovery.

Summary by CodeRabbit

  • Chores
    • Updated the release process to publish generated NuGet packages from the correct output location.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release workflow now runs the NuGet publish step from out and matches .nupkg files in that directory. The API key and NuGet source are unchanged.

Changes: NuGet package publishing

Layer / File(s) Summary
Package publishing
.github/workflows/wf-build-release.yml
The publish step sets out as its working directory and matches *.nupkg there. The API key and NuGet source are unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • Shane32/QRCoder#718: This PR changes the same release workflow and adds NuGet authentication used by the publish step.
Merge Risk: Minimal · up to ffcc9

The release workflow now publishes the built packages from the output directory, which fixes the earlier missing-file failure. No remaining merge-blocking risk was found.

Pre-merge checks: Passed 2

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the main change: the NuGet release publish step now runs from the out directory so the *.nupkg pattern resolves correctly. The raw summary confirms that the workflow pub…
Full details: Title check

Explanation

The title accurately describes the main change: the NuGet release publish step now runs from the out directory so the *.nupkg pattern resolves correctly. The raw summary confirms that the workflow publish step runs from out and pushes *.nupkg there. The objectives describe the same fix, which sets working-directory to out and changes the push pattern to *.nupkg, matching the title.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dc275983-72a0-4030-8423-478a83190a49
Commits

Reviewing files that changed from the base of the PR and between 2f4504a and 8ddf811.

Files selected for processing: 1

  • .github/workflows/wf-build-release.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

@Shane32 Shane32 changed the title Fix package discovery when publishing NuGet releases on Windows Run NuGet release publishing from the package output directory Nov 19, 2026
@Shane32
Shane32 merged commit 9bfb5c8 into master Nov 19, 2026
7 of 8 checks passed
@Shane32
Shane32 deleted the fix-release-package-paths branch November 19, 2026 18:10
This was referenced Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant