You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Simplify date formatting inside AppendInvariant calls - #717
Replace six explicit date ToString calls inside AppendInvariant interpolations with format specifiers: four BezahlCode dates use ddMMyyyy, and the MeCard/vCard birthday fields use yyyyMMdd. The existing invariant interpolation handler preserves the date formats and culture while avoiding intermediate strings on .NET 6+.
The SwissQrCode amount change in #715 is excluded.
Validation: all 48 BezahlCode and ContactData tests passed on both net6.0-windows and net462, exercising both interpolation handler implementations. git diff --check passed.
Summary by CodeRabbit
Refactor
Updated date formatting in payment and contact details. Output date formats remain unchanged.
Shane32/QRCoder#696: Defines the AppendInvariant interpolation API used by these formatting changes.
Suggested reviewers:kamilla11
Merge Risk: Minimal · up to 434b6
This is a small refactor of date formatting in payload generation. Output formats are intended to be unchanged, and no actionable merge risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Simplify date formatting inside AppendInvariant calls" matches the main change. The PR replaces explicit date ToString calls inside invariant interpolations with format specifiers (ddMMyyyy…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Simplify date formatting inside AppendInvariant calls" matches the main change. The PR replaces explicit date ToString calls inside invariant interpolations with format specifiers (ddMMyyyy in BezahlCode, yyyyMMdd for ContactData birthdays). The title is specific and concise, and it names the code area without listing files.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: e0fcf4e8-b70b-43f0-8e3f-05e8b31f5a24
Commits
Reviewing files that changed from the base of the PR and between ca210b7 and 434b682.
Files selected for processing: 2
QRCoder/PayloadGenerator/BezahlCode.cs
QRCoder/PayloadGenerator/ContactData.cs
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace six explicit date ToString calls inside AppendInvariant interpolations with format specifiers: four BezahlCode dates use
ddMMyyyy, and the MeCard/vCard birthday fields useyyyyMMdd. The existing invariant interpolation handler preserves the date formats and culture while avoiding intermediate strings on .NET 6+.The SwissQrCode amount change in #715 is excluded.
Validation: all 48 BezahlCode and ContactData tests passed on both net6.0-windows and net462, exercising both interpolation handler implementations.
git diff --checkpassed.Summary by CodeRabbit