Skip to content

Simplify date formatting inside AppendInvariant calls - #717

Merged
Shane32 merged 1 commit into
masterfrom
simplify-append-invariant-date-formatting
Nov 19, 2026
Merged

Shane32 merged 1 commit into
masterfrom
simplify-append-invariant-date-formatting

Conversation

@Shane32

@Shane32 Shane32 commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Replace six explicit date ToString calls inside AppendInvariant interpolations with format specifiers: four BezahlCode dates use ddMMyyyy, and the MeCard/vCard birthday fields use yyyyMMdd. The existing invariant interpolation handler preserves the date formats and culture while avoiding intermediate strings on .NET 6+.

The SwissQrCode amount change in #715 is excluded.

Validation: all 48 BezahlCode and ContactData tests passed on both net6.0-windows and net462, exercising both interpolation handler implementations. git diff --check passed.

Summary by CodeRabbit

  • Refactor
    • Updated date formatting in payment and contact details. Output date formats remain unchanged.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Date formatting in BezahlCode, MeCard, and vCard output now uses interpolated format strings. Other payload construction remains unchanged.

Changes: Payload date formatting

Layer / File(s) Summary
Format dates in payload output
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/ContactData.cs
BezahlCode date fields use ddMMyyyy formatting. MeCard and vCard birthdays use yyyyMMdd formatting.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Possibly related PRs

  • Shane32/QRCoder#696: Defines the AppendInvariant interpolation API used by these formatting changes.

Suggested reviewers: kamilla11

Merge Risk: Minimal · up to 434b6

This is a small refactor of date formatting in payload generation. Output formats are intended to be unchanged, and no actionable merge risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Simplify date formatting inside AppendInvariant calls" matches the main change. The PR replaces explicit date ToString calls inside invariant interpolations with format specifiers (ddMMyyyy…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Simplify date formatting inside AppendInvariant calls" matches the main change. The PR replaces explicit date ToString calls inside invariant interpolations with format specifiers (ddMMyyyy in BezahlCode, yyyyMMdd for ContactData birthdays). The title is specific and concise, and it names the code area without listing files.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e0fcf4e8-b70b-43f0-8e3f-05e8b31f5a24
Commits

Reviewing files that changed from the base of the PR and between ca210b7 and 434b682.

Files selected for processing: 2

  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/ContactData.cs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@Shane32
Shane32 merged commit b49d45d into master Nov 19, 2026
8 checks passed
@Shane32
Shane32 deleted the simplify-append-invariant-date-formatting branch November 19, 2026 17:03
This was referenced Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant