constant default_move_duration prevents appium to override it

[prakharrr]

• By placing an X in the preceding checkbox, I verify that I have signed the Contributor License Agreement

[luke-hill]

if you want to remove the constant, the best way of defining it will be as a private memoized method

private

def default_move_duration
  @default_move_duration ||= 0.25
end

You also can remove the reader and writer, as the writer isn't used and the reader becomes this memo

[titusfortner]

The reason for this PR is that the constant is being overridden in the Appium library, so this would change to specifically allow a writer.

[luke-hill]

That's fair, I still wouldn't have procedurally defined instance vars, but each to their own.

[titusfortner]

There's no reason to wrap the default in a method. Leverage the accessor.

[p0deje]

Looks good, but please fix unit tests and RuboCop:

./go //rb:unit-test
./go //rb:lint

[titusfortner]

since this is no longer a constant, it needs to be referenced as a method on the class that includes the PointerActions module. In this case, builder. Update this to be:

      let(:duration) { builder.default_move_duration }

[prakharrr]

lint and unit test works now.

[p0deje]

Looks good. Titus, please merge 👍