refactor(root): move profile registry, cloud, and telemetry owners - #1147
Open
ScriptedAlchemy wants to merge 6 commits into
Open
refactor(root): move profile registry, cloud, and telemetry owners#1147ScriptedAlchemy wants to merge 6 commits into
ScriptedAlchemy wants to merge 6 commits into
Conversation
Move exact-final forget/gc/wipe helpers out of the composition root. The type wraps an already-admitted profile lease so global-db never opens store-runtime.
The CLI binary did not declare store-runtime, so the admit helper could not open an existing profile lease.
The composition root cannot depend on the CLI binary, so doctor takes admitted ureq probes and MCP looks up the same implementations admitted at process start.
Move the crate-private collection pass off the composition root. Handlers assemble the wire snapshot from kernel facts plus admitted census and registry projection values.
…plan-reopened' into grok/w1-small-owners
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a11c42a876
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| clru = "0.6" | ||
| hotpath.workspace = true | ||
| schemars = "1.2.1" | ||
| semver = "1" |
There was a problem hiding this comment.
With the version-comparison implementation and its semver import moved into tracedecay-dashboard-api, a repository-wide search finds no remaining semver usage under crates/tracedecay, but crates/tracedecay/Cargo.toml:363 still declares it as a direct dependency. Remove that stale declaration so the composition-root manifest reflects its actual crate boundary and does not retain an unused dependency after the cutover.
AGENTS.md reference: AGENTS.md:L113-L120
Useful? React with 👍 / 👎.
Contributor
Performance Comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child of #707 for #1073 (composition root). Three small leftovers move to their owners; root
cloud.rs,profile_registry_maintenanceglue, andruntime_telemetry.rs(197 lines) are gone.refactor(global-db): exact-final profile-registry forget/gc/wipe helpers move intotracedecay-global-dbas a type wrapping an already-admitted profile lease, so global-db never opens store-runtime.fix(cli): the CLI binary now declares store-runtime so the admit helper can open an existing profile lease.refactor(cli): sync cloud version checks (ureq) move totracedecay-cli; the composition root cannot depend on the CLI binary, so doctor takes admitted ureq probes and MCP looks up the implementations admitted at process start (tracedecay-dashboard-api/src/cloud.rscarries the shared shape).refactor(runtime-core): the crate-private store telemetry collection pass moves totracedecay-runtime-core::store_telemetry; MCP health handlers assemble the wire snapshot from kernel facts plus admitted census and registry projection values.Remaining root leftovers are composition surfaces (doctor, dashboard, serve, runtime_ports) and the mcp/daemon owners covered by other child PRs. Touches
mcp/server/{connection,ledger,lifecycle}.rs(also in #1135) for import/callsite lines only.Verified locally per commit (check/clippy
-D warningson the touched crates, storage_suiteglobal_registry_test/projects_forget_test, fmt, commitlint); merged #7073473b1f92. Full matrix on CI.