refactor(graph-query): move root graph analysis into graph-query - #1141
Merged
ScriptedAlchemy merged 2 commits intoSep 9, 2026
Merged
ScriptedAlchemy merged 2 commits into
ScriptedAlchemy merged 2 commits into
Conversation
The crate-private redundancy and test-risk scans now consume the admitted VerifiedGraphQuery handle instead of TraceDecay, so the composition root can drop its graph module without a new port.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38f32d655c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+427
to
+428
| async fn file_churn(project_root: &Path, days: u32) -> Result<HashMap<String, usize>> { | ||
| let git = tracedecay_runtime_core::git::try_git_program().map_err(|_| { |
There was a problem hiding this comment.
This copies tracedecay_application::git_intelligence::churn::file_churn nearly verbatim while removing its last repository caller, leaving two production implementations with separate instrumentation and error policies. When the Git command or failure handling changes, test-risk can silently diverge from the canonical helper; move the implementation to a lower-layer crate that both modules can use instead of introducing this shadow authority.
AGENTS.md reference: AGENTS.md:L113-L120
Useful? React with 👍 / 👎.
Contributor
Performance Comparison
|
ScriptedAlchemy
merged commit Sep 9, 2026
001480a
into
codex/tracedecay-total-redesign-plan-reopened
11 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child of #707 for #1073 (composition root).
crates/tracedecay/src/graph/**is deleted; redundancy scan and test-risk analysis now live intracedecay-graph-queryas public modules and take the already-admittedVerifiedGraphQueryhandle. No new port, nomcp ↔ graph-querycycle, no compatibility re-export from the old root path.redundancy_scan:redundancy_scan,RedundancyOptions,RedundancyScanV1, pair/node views, and the scan-ownedSemanticRedundancy{Generation,Profile,Vector}V1(application still projects the generation and re-exports the types).test_risk:analyze_test_risk,verified_test_evidence,verified_test_symbol_parts,VerifiedTestEvidence,TestRiskReportand its summary/entry/bucket types.TraceDecayis removed from these signatures so graph-query does not depend on root or application. Handlers fetch semantic viaproject_semantic_redundancy_generation; test-risk reads churn fromgraph.project_root().Verification:
tracedecay-graph-query55 tests;mcp_suite(test-transport) 11 tests — redundancy, health summary/detailed, test_risk ×4, test_map, context search-evidence scope, search limit/budget; check + clippy-D warningson graph-query/application/root; fmt; commitlint.