refactor(hooks): move Hook V2 replay drain into tracedecay-hooks - #1139
Conversation
Pass an admitted host spool and project id so the root crate no longer opens or owns that drain path.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Performance Comparison
|
a75d6a1
into
codex/tracedecay-total-redesign-plan-reopened
Child of #707 for #1073 (composition root).
Hook V2 spool drain moves from the root crate into
tracedecay-hooksasdrain_host_spool_once(spool, project_id, binding, now, admit). The daemon keeps onlyhook_v2_replay_consumer.rs, which admits a host spool, passes the project id, and maps typed admission outcomes. No TraceDecay port, no compatibility re-export; the roothook_v2_replay.rsis deleted.Behavior preserved:
Backpressured/Unavailableretain records; stale/conflict/expired tombstone. New: a foreign project id isbinding_unavailableand retains records (tested).Verification: 13
hook_v2_replaytests intracedecay-hookspass; clippy-D warningsontracedecay-hooksandtracedecay; fmt; commitlint.