-
Notifications
You must be signed in to change notification settings - Fork 98
service: resolve relative __next URLs against the service root #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+43
−1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -297,13 +297,19 @@ def add_headers(self, value): | |
| def _build_request(self): | ||
| if self._next_url: | ||
| parsed_next = urlparse(self._next_url) | ||
| # OData v2 allows relative __next values; resolve them against the service root. | ||
| if not parsed_next.scheme and not parsed_next.netloc: | ||
| resolved = urljoin(self._url, self._next_url) | ||
| parsed_next = urlparse(resolved) | ||
|
Comment on lines
+302
to
+303
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not see the reason for not doing this: the code below just checks the scheme and host and it comes from |
||
| else: | ||
| resolved = self._next_url | ||
| parsed_base = urlparse(self._url) | ||
| if (parsed_next.scheme, parsed_next.netloc) != (parsed_base.scheme, parsed_base.netloc): | ||
| raise PyODataException( | ||
| f'cross-origin __next URL rejected: {self._next_url!r} differs from ' | ||
| f'service root {self._url!r}' | ||
| ) | ||
| url = self._next_url | ||
| url = resolved | ||
| else: | ||
| url = urljoin(self._url, self.get_path()) | ||
| # pylint: disable=assignment-from-none | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make the condition more strict. If the
_next_urlhas scheme or netloc, then treat it as absolute URL and not just path.