Repository navigation
Fix Windows wheel build and inherited flow-control, typing, and profiling CI failures - #121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.65 Windows wheel build fails with E0308 because transport state now returns a SnapshotGuard, while Condvar::wait_timeout requires a standard MutexGuard. Use SnapshotMutex::wait_timeout in wait_for_poll_reader to publish dirty flags before unlocking and restore the wrapped guard after waiting.
This also repairs failures inherited from master (37a3d3f), discovered by PR CI:
Validation:
Release recovery: retain v0.1.65 at 37a3d3f. After this PR is green and merged, bump Cargo.toml/Cargo.lock/pyproject.toml/uv.lock together to 0.1.66 using Update Version. Verify the resulting master revision, manually run Tests and Wheels on that branch as validation and a build-only preflight, inspect all six platform wheel jobs and installed free-threaded checks, then create a new v0.1.66 tag at that exact revision. Tagged Wheels performs trusted PyPI publishing. Do not rerun the old tag to obtain patched sources. At the investigation time PyPI still has 0.1.64 as latest, no 0.1.65 files, and no 0.1.66 release; recheck version availability immediately before publishing. This PR does not merge, retag, or publish a release.