Repository navigation
Remove Null host - #1386
Remove Null host#1386Marco-Farruggio wants to merge 8 commits into
Conversation
|
Related: I think #571 can be closed because WASI doesn't support audio, and the proposed |
|
I have closed #571 . Think you can get CI to pass? |
|
Sorry, I only just saw this notification, and yes, I'll put some time aside tomorrow to get this ready to merge :) |
|
What do you think is a better idea for when there is no cpal host available for a certain compilation target and
|
|
Well it actually can't currently return |
|
Just do whatever is easier right now, we can always change it later |
e7b0277 to
48bd742
Compare
…grading, fix formatting
|
Why do we have CI checks for WASI when it's unsupported? They won't pass anymore as I emit a compilation error |
|
No idea. Just remove them |
|
I think the WASM checks were actually all emitting false positives, as after removing the |
|
Welp one removed null host later, a lot of comments, doc rewriting, and going down a CI rabbit hole for me, I think it's ready for merging 😅 |
Remove the null host, add a compilation error on unsupported targets, and updated the documentation. To me expecting cpal to compile on a target with no audio capabilities is like expecting a GUI library to compile on a target with no display server, which should really be a build error. This also means its less clutter in the codebase which is always a plus.
Closes #1366