[ALSA] supported_formats panics on certain device #227

Activity

1. armyofevilrobots commented on Mar 2, 2019

   

   armyofevilrobots

   on Mar 2, 2019

   Last edited by armyofevilrobots

   More actions

   Same here:

           for device in cpal::devices(){
               let formats = device.supported_input_formats(); // LINE 100
               match formats{
                   Ok(formats) => {
                        for format in formats{
                            info!("Device {} has IN_FORMAT: ch:{}, fmt:{:?}",
                                  &device.name(), format.channels, format.data_type);
                        }
                   }
                   Err(_) => {
                       error!("Unable to find supported formats in device {}. Disconnect?", &device.name());
                   }
               }
           }

   Results in:

   ALSA lib pcm_dmix.c:1035:(snd_pcm_dmix_open) The dmix plugin supports only playback stream
   ALSA lib pcm_dmix.c:1035:(snd_pcm_dmix_open) The dmix plugin supports only playback stream
   thread 'main' panicked at 'device not available: "Invalid argument"', src/libcore/result.rs:1009:5
   stack backtrace:
      0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
                at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
      1: std::sys_common::backtrace::_print
                at src/libstd/sys_common/backtrace.rs:71
      2: std::panicking::default_hook::{{closure}}
                at src/libstd/sys_common/backtrace.rs:59
                at src/libstd/panicking.rs:211
      3: std::panicking::default_hook
                at src/libstd/panicking.rs:227
      4: std::panicking::rust_panic_with_hook
                at src/libstd/panicking.rs:491
      5: std::panicking::continue_panic_fmt
                at src/libstd/panicking.rs:398
      6: rust_begin_unwind
                at src/libstd/panicking.rs:325
      7: core::panicking::panic_fmt
                at src/libcore/panicking.rs:95
      8: core::result::unwrap_failed
                at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/libcore/macros.rs:26
      9: <core::result::Result<T, E>>::expect
                at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/libcore/result.rs:835
     10: cpal::cpal_impl::Device::supported_formats
                at /home/derek/.cargo/registry/src/github.life-white.uk-1ecc6299db9ec823/cpal-0.8.2/src/alsa/mod.rs:95
     11: cpal::cpal_impl::Device::supported_input_formats
                at /home/derek/.cargo/registry/src/github.life-white.uk-1ecc6299db9ec823/cpal-0.8.2/src/alsa/mod.rs:252
     12: cpal::Device::supported_input_formats
                at /home/derek/.cargo/registry/src/github.life-white.uk-1ecc6299db9ec823/cpal-0.8.2/src/lib.rs:374
     13: onair_sonoff::main
                at src/main.rs:100
     14: std::rt::lang_start::{{closure}}
                at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/libstd/rt.rs:74
     15: std::panicking::try::do_call
                at src/libstd/rt.rs:59
                at src/libstd/panicking.rs:310
     16: __rust_maybe_catch_panic
                at src/libpanic_unwind/lib.rs:102
     17: std::rt::lang_start_internal
                at src/libstd/panicking.rs:289
                at src/libstd/panic.rs:398
                at src/libstd/rt.rs:58
     18: std::rt::lang_start
                at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/libstd/rt.rs:74
     19: main
     20: __libc_start_main
     21: _start
   
   
2. armyofevilrobots commented on Mar 4, 2019

   

   armyofevilrobots

   on Mar 4, 2019

   More actions

   Looking at:
   https://github.com/michaelwu/alsa-lib/blob/master/src/pcm/pcm.c#L2063
   I can see a ton of places that return -EINVAL, and I don't expect any downside to just returning the same kind of format enumeration error... Unless there is some kinda cleanup we need to do there.

   Regardless, I'm going to attach a very simple PR to this issue, since the change is completely fixed in my env with this one-liner, and I haven't seen any stability impact yet.
3. armyofevilrobots

   added a commit that references this issue on Mar 4, 2019

   Fix RustAudio#227 by handling EINVAL

   ...

   This issue will close once commit f39f0dc is merged into the 'master' branch.

   f39f0dc
4. mitchmindtree commented on Jun 21, 2019

   

   mitchmindtree

   on Jun 21, 2019

   Member

   More actions

   This has since been addressed, though I don't remember which commit exactly adds the case for handling the -22 error code. #286 also removes almost all internal panic!s within the synchronous API so it should at least be possible to handle these cases in user code now. Feel free to comment or re-open if this error pops up again!
5. mitchmindtree

   closed this as completedon Jun 21, 2019